Problem/Motivation

Since #2829817: Apply dependency injection (DI) to TruncateHTML class the project uses property type hints, which is a php 7.4.0 feature.

Proposed resolution

Declare requirements of php version >=7.4.0 via composer.json.

Issue fork smart_trim-3317184

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tobiasb created an issue. See original summary.

tobiasb opened merge request !28

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Active » Needs review
erikaagp’s picture

erikaagp commented
Status: Needs review » Reviewed & tested by the community

Good job, well implemented. Moving to RTBC

ultimike made their first commit to this issue’s fork.

  • ultimike committed 07529723 on 2.0.x authored by tobiasb 
    Issue #3317184 by tobiasb, erikaagp: Missing requirements of php >= 7.4....
ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Reviewed & tested by the community » Fixed

Updating status.

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.