Problem/Motivation

Drupal\FunctionalJavascriptTests\Tests\JSWebAssertTest is randomly failing a lot of at the moment.

1) Drupal\FunctionalJavascriptTests\Tests\JSWebAssertTest::testJsWebAssert
Element not exists on page after too short wait.

/var/www/html/core/tests/Drupal/FunctionalJavascriptTests/Tests/JSWebAssertTest.php:46
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:726

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
StatusFileSize
new6.54 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3316224-2.patch, failed testing. View results

alexpott’s picture

Status: Needs work » Needs review
StatusFileSize
new6.46 KB

Let's add a work around here and see if the test goes green.

alexpott’s picture

StatusFileSize
new1.46 KB

I think we should consider doing this because this is testing our testing code and so the randoms disrupting core work don't feel worth it.

spokje’s picture

Status: Needs review » Reviewed & tested by the community

Patch number #4 shows so many green that I'm going to RTBC #5 already.

The comment above the changed code, and thus the changed code itself makes sense seeing the torrent of JS failures lately.

alexpott’s picture

StatusFileSize
new951 bytes
new1.57 KB

  • catch committed 0628fa0 on 10.1.x
    Issue #3316224 by alexpott: Drupal\FunctionalJavascriptTests\Tests\...

  • catch committed 840d04b on 10.0.x
    Issue #3316224 by alexpott: Drupal\FunctionalJavascriptTests\Tests\...
  • catch committed 6c1ba57 on 9.4.x
    Issue #3316224 by alexpott: Drupal\FunctionalJavascriptTests\Tests\...
  • catch committed 50e18ab on 9.5.x
    Issue #3316224 by alexpott: Drupal\FunctionalJavascriptTests\Tests\...
catch’s picture

Version: 10.1.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x, cherry-picked back to 9.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.