Problem/Motivation

Hello,

in core/modules/language/src/LanguageNegotiatorInterface.php, the docblock provides an example of a class extending Drupal\language\Plugin\LanguageNegotiation\LanguageNegotiationUrl.

In this example, we're supposed to override GetLangcode, but at line 79 and 83, the given function's name is GetCurrentLanguage.

Steps to reproduce

Open file modules/language/src/LanguageNegotiatorInterface.php

CommentFileSizeAuthor
#2 drupal-error_in_docblock_of_LanguageNegotitationInterface-3316136-2.patch864 bytesjulien.sibi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

julien.sibi created an issue. See original summary.

julien.sibi’s picture

julien.sibi
Primary language French
CreditAttribution: julien.sibi as a volunteer commented
FileSize
drupal-error_in_docblock_of_LanguageNegotitationInterface-3316136-2.patch864 bytes
julien.sibi’s picture

julien.sibi
Primary language French
CreditAttribution: julien.sibi as a volunteer commented
Status: Active » Needs review
julien.sibi’s picture

julien.sibi
Primary language French
CreditAttribution: julien.sibi as a volunteer commented
flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
CreditAttribution: flocondetoile at Flocon de toile commented
Status: Needs review » Reviewed & tested by the community

Patch looks fine and fix a typo error in the docblock on the available method in the LanguageNegotiationUrl Class extended.

  • catch committed 5745118 on 10.0.x 
    Issue #3316136 by julien.sibi, flocondetoile:...
  • catch committed e7cfffe on 10.1.x
    Issue #3316136 by julien.sibi, flocondetoile:...
  • catch committed e16dac1 on 9.5.x
    Issue #3316136 by julien.sibi, flocondetoile:...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked back to 9.5.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.