Problem/Motivation

We have the string CKEditor5 plugin settings front-and-center in the Text Format & Editor UI 🙈

Steps to reproduce

Go to /admin/config/content/formats/manage/basic_html to observe this.

Proposed resolution

Fix typo.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#8 3315884-8.patch10.5 KBwim leers
#8 interdiff.txt4.11 KBwim leers
#3 3315884-3.patch7.07 KBwim leers
#2 Screen Shot 2022-10-18 at 8.01.28 AM.png124.59 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2022-10-18 at 8.01.28 AM.png124.59 KB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Active » Needs review
StatusFileSize
new 3315884-3.patch7.07 KB

While I was at it, I updated CKEditor5 to CKEditor 5 everywhere. Because consistency is important.

+++ b/core/modules/ckeditor5/src/Plugin/Editor/CKEditor5.php
@@ -392,7 +392,7 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta
-      '#title' => $this->t('CKEditor5 plugin settings'),
+      '#title' => $this->t('CKEditor 5 plugin settings'),

This is the one that is necessary to fix the reported bug.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Fix UI label typo » Fix UI label typo: s/CKEditor5/CKEditor 5/
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

#3 applies cleanly to <10.0.x, 9.5.x and 9.4.x too 👍

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Title: Fix UI label typo: s/CKEditor5/CKEditor 5/ » Fix typos: s/CKEditor5/CKEditor 5/
Status: Needs review » Needs work

I first ran grep -re 'CKEditor5\s' core/modules/ckeditor5 and all looked good. 👍 However, I did find few more instances of CKEditor5 by using grep -re '\sCKEditor5\b' core/modules/ckeditor5:

  1. \Drupal\Tests\ckeditor5\FunctionalJavascript\CKEditor5FragmentLinkTest::testFragmentLink
  2. \Drupal\Tests\ckeditor5\FunctionalJavascript\AdminUiTest::testUnavailableFiltersHiddenWhenSwitching
  3. \Drupal\Tests\ckeditor5\FunctionalJavascript\CKEditor5AllowedTagsTest

I also noticed we still have core/modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/README.md in the code base and it's totally out of date. 🙈 We should probably open a follow-up for removing this.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt4.11 KB
new 3315884-8.patch10.5 KB

Nice catches. Done.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Reviewed & tested by the community

All looks good with #8 👍 I used the commands from #7 to confirm that all of the remaining results on #8 are fine as is.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#3317332: Remove obsolete core/modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/README.md

Follow-up created: #3317332: Remove obsolete core/modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/README.md.

catch’s picture

catch
he/him
Primary language English
commented
Version: 10.1.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!

This is a string change which normally we wouldn't backport to a patch release, but maybe we can because CKEditor 5 is still experimental - moving to PTBP for now.

  • catch committed e5a418e on 10.0.x 
    Issue #3315884 by Wim Leers, lauriii: Fix typos: s/CKEditor5/CKEditor 5...
  • catch committed a575c44 on 10.1.x
    Issue #3315884 by Wim Leers, lauriii: Fix typos: s/CKEditor5/CKEditor 5/
  • catch committed 2c46b5a on 9.5.x
    Issue #3315884 by Wim Leers, lauriii: Fix typos: s/CKEditor5/CKEditor 5...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

I'm fine with either way — I defer to you, release managers :)

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 9.4.x-dev » 9.5.x-dev
Status: Patch (to be ported) » Fixed

Discussed with @catch. The existing string is already translated for several languages in 9.4.x and we should not break that now.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

👍

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.