Problem/Motivation

When one adds a group member and there is a node with ID equal to userID, the node also becomes the group member.

Steps to reproduce

1. Install group module ( https://www.drupal.org/project/group ) version 3.0․
2. Enable group and group node modules.
3. Create Group Type -> Group1 (admin/group/types/add) and install /admin/group/types/manage/group1/content basic_page(content type).
4. Create 2 nodes. title = Node1 (url = lndo.site/node/1) and title = Node2 (url = lndo.site/node/2).
5. Create 2 new users, ids will be 2 and 3.
6. Create a group Test.
7. Go to group Nodes ( group/1/nodes ).
Expected result: Empty list
Actual result: A node with id 1 appears in a list.

And if one adds new member whose id exists in nodes ids (ex. user/2 , node/2) the node will appear in a list (becomes group member content)

CommentFileSizeAuthor
#29 group-3315779-29-2.patch3.66 KBkristiaanvandeneynde
#29 group-3315779-29-3.patch3.66 KBkristiaanvandeneynde
#21 group_module_member_3315779_9.patch1.21 KBkksandr
#19 group_module_member_3315779_8.patch804 bytesartyom hovasapyan
#18 group_module_member_3315779_6.patch1.71 KBartyom hovasapyan
#17 group_module_member_3315779_5.patch1.78 KBartyom hovasapyan
Screenshot from 2022-10-17 18-39-59.png90.91 KBartyom hovasapyan
Screenshot from 2022-10-17 18-56-37.png81.07 KBartyom hovasapyan
Screenshot from 2022-10-17 18-56-37.png81.07 KBartyom hovasapyan
#7 group_module_member_patches.patch638 bytesartyom hovasapyan
#8 group_module_member_3315779.patch638 bytesartyom hovasapyan
#12 group_module_member_3315779_2.patch1.72 KBartyom hovasapyan
#15 group_module_member_3315779_3.patch1.75 KBartyom hovasapyan
#16 group_module_member_3315779_4.patch1.78 KBartyom hovasapyan

Issue fork group-3315779

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Artyom Hovasapyan created an issue. See original summary.

artyom hovasapyan’s picture

artyom hovasapyan commented
Issue summary: View changes
artyom hovasapyan’s picture

artyom hovasapyan commented
Issue summary: View changes
artyom hovasapyan’s picture

artyom hovasapyan commented
Title: Group 3@beta module have member » Wired behavior. Nodes are appearing in a group when add a member.
Project: Custom add another » Group
Version: 8.x-1.x-dev » 3.0.0-beta3
Issue summary: View changes
Related issues: -#3313745: Membership invite can be sent to group members, -#2774729: Owner ID of Group membership should be set from User entity
artyom hovasapyan’s picture

artyom hovasapyan commented
Status: Active » Needs work
artyom hovasapyan’s picture

artyom hovasapyan commented
Related issues: +#3315579: "Group nodes (content)" view displays wrong data.
artyom hovasapyan’s picture

artyom hovasapyan commented
StatusFileSize
new group_module_member_patches.patch638 bytes
artyom hovasapyan’s picture

artyom hovasapyan commented
Status: Needs work » Fixed
StatusFileSize
new group_module_member_3315779.patch638 bytes
artyom hovasapyan’s picture

artyom hovasapyan commented
artyom hovasapyan’s picture

artyom hovasapyan commented
Status: Fixed » Needs review

Status: Needs review » Needs work

The last submitted patch, 8: group_module_member_3315779.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

artyom hovasapyan’s picture

artyom hovasapyan commented
StatusFileSize
new group_module_member_3315779_2.patch1.72 KB
artyom hovasapyan’s picture

artyom hovasapyan commented

Artyom Hovasapyan opened merge request !68

artyom hovasapyan’s picture

artyom hovasapyan commented
StatusFileSize
new group_module_member_3315779_3.patch1.75 KB
artyom hovasapyan’s picture

artyom hovasapyan commented
StatusFileSize
new group_module_member_3315779_4.patch1.78 KB
artyom hovasapyan’s picture

artyom hovasapyan commented
StatusFileSize
new group_module_member_3315779_5.patch1.78 KB
artyom hovasapyan’s picture

artyom hovasapyan commented
StatusFileSize
new group_module_member_3315779_6.patch1.71 KB
artyom hovasapyan’s picture

artyom hovasapyan commented
StatusFileSize
new group_module_member_3315779_8.patch804 bytes
ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented

I can confirm this behavior in Group 3.0.0-beta3 and that applying the patch in #19 appears to solve this issue.

-mike

kksandr’s picture

kksandr commented
StatusFileSize
new group_module_member_3315779_9.patch1.21 KB
kksandr’s picture

kksandr commented
Status: Needs work » Needs review
dudeweb’s picture

dudeweb commented

I confirm I had that weird thing as well. Adds to the other bug here https://www.drupal.org/project/group/issues/2842630

dudeweb’s picture

dudeweb commented

Ptach works. Thanks!

kristiaanvandeneynde credited FiNeX.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented

Thanks for the report, will look into this. Meanwhile crediting FiNeX for their detailed report in #3315579: "Group nodes (content)" view displays wrong data.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Title: Wired behavior. Nodes are appearing in a group when add a member. » Weird behavior. Nodes are appearing in a group when add a member.
finn lewis’s picture

finn lewis
Location Oxford
commented

Me too!

I confirm this behaviour in Group 3.0.0-beta3 and that applying the patch in #19 appears to solve this issue.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
StatusFileSize
new group-3315779-29-3.patch3.66 KB
new group-3315779-29-2.patch3.66 KB

Try one of these.

finn lewis’s picture

finn lewis
Location Oxford
commented

Thanks for the updated patches @kristiaanvandeneynde.

Tested group-3315779-29-3.patch from #29 and it works for me. Our duplicate content listings have gone. Thank you!

Guessing you might want someone to test the 2.x version before making this RTBC?

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed

Seems to fix things, would be awesome if someone could write a test for this. (I manually tested the v2 patch and don't have time to write automated tests for the OOTB views configs)

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented

Thank you, @kristiaanvandeneynde!

-mike

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.