Problem/Motivation

In the FloodUnblockManager, the getEventIds method does not filter by event, meaning it returns event IDs from unrelated events, so if there's other custom modules in play - a clear of login related events clears out all of the other events too.

Steps to reproduce

-

Proposed resolution

Filter by event

Remaining tasks

-

User interface changes

None

API changes

None

Data model changes

None

Issue fork flood_control-3315536

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Driskell created an issue. See original summary.

driskell’s picture

driskell commented
Version: 2.2.x-dev » 2.0.x-dev

OK bit confused as it looks like the 2.2.x tags are on the 2.0.x branch and 2.2.x branch is missing some code. I'll change this to 2.0.x

Driskell opened merge request !24

driskell’s picture

driskell commented
Status: Active » Needs review

Added missing filter and also fixed up incorrect parameters on the interface

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Assigned: Unassigned » fabianderijk
Status: Needs review » Reviewed & tested by the community

I reviewed & tested these changes.

@fabianderijk can you merge this?

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented

fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented
Status: Reviewed & tested by the community » Fixed

The MR has been merged to the 2.0.x branch

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented

OK bit confused as it looks like the 2.2.x tags are on the 2.0.x branch and 2.2.x branch is missing some code. I'll change this to 2.0.x

@Driskell: Thanks for pointing this out. We'll fix this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.