Task: Make "Add to Calendar" translatable.

We're using the "modal dialog" configuration. Seems like the Button text and modal title both come from this line:

https://git.drupalcode.org/project/addtocal_augment/-/blob/1.0.x/js/moda...

If it were PHP, I'd say "not a t-string" but in Javascript, no idea :-/

CommentFileSizeAuthor
#5 addtocal_augment-3314754.patch1.7 KBtobiasb
#2 addtocal_augment-3314754.patch351 bytestobiasb

Comments

hexabinaer created an issue. See original summary.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Version: 1.0.0 » 1.1.x-dev
Status: Active » Needs review
StatusFileSize
new addtocal_augment-3314754.patch351 bytes

Just a missing Drupal.t.

hexabinaer’s picture

hexabinaer
Location Berlin, Germany
commented

Reviewing ...

Modal title now translatable, yay!

Button label: needs work.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Needs review » Needs work

todo:

Remove t in https://git.drupalcode.org/project/addtocal_augment/-/blob/1.1.x/src/Plu... and make it translatable via config schema.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Title: Button/modal title not translatable » [PP -1] Button/modal title not translatable
Status: Needs work » Postponed
StatusFileSize
new addtocal_augment-3314754.patch1.7 KB

Needs the patch of #3372635: Fix configuration schema.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Title: [PP -1] Button/modal title not translatable » Button/modal title not translatable
Status: Postponed » Needs review

Patch was commited and part of a release.

  • tobiasb authored 80f4a64c on 1.1.x 
    Issue #3314754 by tobiasb, hexabinaer: Button/modal title not...
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Needs review » Fixed

Patch was commited and part of a release.

Thanks for the heads up. Committing to the 1.1.x branch, which already has a Composer dependency on the 1.1.x branch of date_augmenter.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mrshowerman’s picture

mrshowerman
Location Munich
commented

I see that now both the terms "Add to Calendar" and "Add to calendar" are used. I guess only the latter is correct and should be the base for translations. Do we need a follow-up for this?

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented

I would say yes.

mrshowerman’s picture

mrshowerman
Location Munich
commented

Created #3415008: Tidy up translatable strings.