Drupal 9.4.x compatibility

The 5.x branch isn't anymore supported.

@apaderno 5.x still supported for old projects

Project maintainers took off the check on Supported for that branch, which I take it means they aren't changing its code anymore.

+1 RTBC
On my project, it looks good. But we still need more than 1 approval.

To apply the patch correctly and not break anything, I added a fork branch to the composer repo and installed the current dev branch

   "repositories": [
        {
            "type": "git",
            "url": "git@git.drupal.org:issue/rocketship_core-3314690.git"
        }
    ],

composer require "drupal/rocketship_core:dev-3314690-drupal-9.4.x-compatibility as 5.0" --update-no-dev

@apaderno Version 5.x is indeed no longer supported, meaning that the version is no longer being improved. But the module has an extremely large number of dependencies, updating which is important for projects with an old version 5.x.
For version 6.x we have another issue #3313644: Drupal 9.4.x compatibility

When project maintainers mark a branch as not supported, that means they don't want anymore to commit code for that branch. I would not expect maintainers to commit code for a branch they marked as unsupported.

Hi @apaderno,

This is an internal decision, we agreed to do some upgrade to let existing projects move to newer drupal core version without a pain. Please stop complaining about this.

@nginex I am not complaining. I replied to a user who isn't a maintainer, who didn't say the decision was taken by the project maintainers.

@apaderno, I'm glad that it's clear now.

In fact, it was decided by Dropsolid. As mainteiners we are going to fix and improve a lot of stuff for this module, so new releases coming soon

Updated the patch related to #3008292: ImageItem::getUploadValidators() should be the source of truth for validating uploaded images because the current patch is causing an ajax error when trying to open the media library on ckeditor

Hi @sdstyles
advagg patches already marked as fixed which means that they will be merged soon.
Also, compatibility patches like these are always promptly added to the release.
To resolve possible future composer issues a removed those patches from the MR. It's much better to add them separately.

And it's not clear to me, why the colorbox module was downgraded? Several projects with rocketship_core 5.x have already updated the colorbox module to version 2.0 and found no issues. So I rollbacked the version for colorbox again.

I apologise about colorbox, missed the MR comment why it was downgraded. If you found some issues related to the last version of the module, then it's better to keep the old one.

@hitchshock the advagg patches should not be removed. They are committed in 6.x of advagg (which only has an alpha release to which they are added). Rocketship still is on advagg 5.x, where those fixes are not in, so we still need them here. Unless we block this issue on the release of 6.0 (stable) of advagg (which i would not do).

@mallezie Hmm... interesting. They really merged patches only to the 6.x release and it looks like 5.x won't be updated anymore.
Even though I don't like adding PHP8.1 compatibility patches in the context of the Drupal 9.4 compatibility issue. I have to agree that in this particular case, it is a good solution.
Reverted my commit.

Thanks! That looks good to me. So RTBC it is.

I agree in some cases it's not good to chase patches which are close or already in dev versions committed.

Available in the new release