Olivero's autocomplete-loading-module.pcss.css file (https://git.drupalcode.org/project/drupal/-/blob/10.0.x/core/themes/oliv...) should be refactored.

When doing this

  • Remove unneeded IE11 compatibility code.
  • Componentize CSS custom properties to element
  • Create new custom properties to make code more portable
  • Utilize the :dir(rtl) and nesting (which will be transpiled by PostCSS)
CommentFileSizeAuthor
#10 rtl.gif44.3 KBckrina
#7 3314532-7-reroll.patch11.23 KBmherchel
#5 3314532.png179.02 KBgajendra_sharma
#2 3314532.patch11.25 KBmherchel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Status: Active » Needs review
FileSize
3314532.patch11.25 KB

Patch attached. Note this removes a lot of legacy code (the file was derived from Claro's CSS), in addition to IE compatible code.

The resulting code is a lot smaller, and really didn't have any need for custom CSS properties, so there are none.

Status: Needs review » Needs work

The last submitted patch, 2: 3314532.patch, failed testing. View results

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Status: Needs work » Needs review
gajendra_sharma’s picture

gajendra_sharma CreditAttribution: gajendra_sharma at Dotsquares Ltd. commented
Status: Needs review » Needs work
FileSize
3314532.png179.02 KB

In #2 Patch 3314532.patch is corrupted and failed to apply patch see in screenshot

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Status: Needs work » Needs review

@gajendra_sharma Thanks for the comment.

The reason the file looks corrupted is because I'm deleting a binary file (the spinning gif). The patch is correct, although we're running into some random test failures.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
FileSize
3314532-7-reroll.patch11.23 KB

Re-roll

Status: Needs review » Needs work

The last submitted patch, 7: 3314532-7-reroll.patch, failed testing. View results

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Status: Needs work » Needs review
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
CreditAttribution: ckrina at Lullabot commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
rtl.gif44.3 KB

This looks great!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 10.1.x-dev » 10.0.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 55c7c51e14 to 10.1.x and b13a431963 to 10.0.x. Thanks!

  • alexpott committed 55c7c51 on 10.1.x 
    Issue #3314532 by mherchel, ckrina: Refactor Olivero's autocomplete-...

  • alexpott committed b13a431 on 10.0.x 
    Issue #3314532 by mherchel, ckrina: Refactor Olivero's autocomplete-...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.