Problem/Motivation

Steps to reproduce

Proposed resolution

remove core :8.x in info.yml file

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#17 3313868-17.patch514 bytesemarinho
#3 3313868-3.patch976 bytessahil rohilla01
#2 3313868-2.patch2.33 KBsahil rohilla01

Issue fork cleantaxonomy-3313868

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3313868 Comparecompare
    • 1 hidden branch
  • 3313868-no-need-to Comparechanges, plain diff MR !2
About issue forks

Comments

SAHIL ROHILLA01 created an issue. See original summary.

sahil rohilla01’s picture

sahil rohilla01 commented
Assigned: sahil rohilla01 » Unassigned
Status: Active » Needs review
StatusFileSize
new 3313868-2.patch2.33 KB

removed core:8.X from info.yml file

sahil rohilla01’s picture

sahil rohilla01 commented
StatusFileSize
new 3313868-3.patch976 bytes

Removed core:8.X from info.yml file . Please ignore #2 comment

emarinho’s picture

emarinho commented
Assigned: Unassigned » emarinho

Ok! I'll review it!

emarinho’s picture

emarinho commented
Status: Needs review » Needs work

Hi, @SAHIL ROHILLA01! How is it going?
I tried to apply the patch but I couldn't, it returned me an error. So, I'll work on it to solve the issue.

emarinho opened merge request !2

emarinho’s picture

emarinho commented
Assigned: emarinho » Unassigned
Status: Needs work » Needs review

Did the change by a MR, so please kindly review it :)

cinarb’s picture

cinarb commented
Assigned: Unassigned » cinarb

Hi Ill review this

cinarb’s picture

cinarb commented
Assigned: cinarb » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi, @emarinho I can see "core :8.x" was removed. Ill move this issue to RTBC.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work

If core is removed, then core_version_requirement needs to be updated, since not all the Drupal 8 versions handle that key.

Instead of ^8 || ^9, it should be ^8.8 || ^9

emarinho’s picture

emarinho commented
Assigned: Unassigned » emarinho

Thanks, @apaderno! I'll fix it! :)

emarinho’s picture

emarinho commented
Assigned: emarinho » Unassigned
Status: Needs work » Needs review

Just pushed a commit fixing the 'core_version_requirement: ^8.8 || ^9' as suggested by @apaderno. Please, review it. Thanks!!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

In the issue fork there are many changes that aren't related to this issue.

emarinho’s picture

emarinho commented
Assigned: Unassigned » emarinho

Ok! I'll check it!

emarinho closed merge request !2

elber made their first commit to this issue’s fork.

emarinho’s picture

emarinho commented
Assigned: emarinho » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3313868-17.patch514 bytes

Hi there! I couldn't make to push only my commit in the MR, really don't know where all those other commits came from. So, I created a patch to fix the issue. Hope it helps. Please, review it. Thanks!!

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Needs review » Reviewed & tested by the community

Hi I reviewed and for me it is good, the patch solved the problem mentioned in comment #10

  • 9763c82 committed on 8.x-1.x 
    Issue #3313868 by emarinho, SAHIL ROHILLA01, elber: No need to add core...
gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Reviewed & tested by the community » Fixed

Thanks, everyone for working on this. I will be adding a new release after reviewing a few recently updated issues.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.