Problem/Motivation

  • Add the SPA form and REST API to edit the AWS Cloud launch template in the Cloud module.

Issue fork cloud-3313812

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1360

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the patch. I posted my comments. Can you please check them? Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Assigned: Unassigned » ryo yamashita
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3311749: Add a REST API to copy the AWS Cloud launch template in the Cloud module, +#3314652: Add the SPA form and REST API to review the AWS Cloud launch template in the Cloud module
ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I rebased and fixed this patch. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. Can you please rebase the patch? Thanks

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I rebased this patch. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for rebasing the patch. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 9e4592d on 5.x authored by Ryo Yamashita 
    Issue #3313812 by Ryo Yamashita, yas: Add the SPA form and REST API to...

  • yas committed 722b6c1 on 4.x 
    Issue #3313812 by Ryo Yamashita, yas: Add the SPA form and REST API to...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.