Problem/Motivation

Module contains a few coding standard errors and warnings (as shown in file)

Steps to reproduce

Run PHPCS with Drupal coding standards

Proposed resolution

Simple re-writing

Remaining tasks

MR with fix

CommentFileSizeAuthor
restui_coding_std.txt1.85 KBjmizarela

Issue fork restui-3313528

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jmizarela created an issue. See original summary.

jmizarela opened merge request !3

jmizarela’s picture

jmizarela commented
Assigned: jmizarela » Unassigned
Issue summary: View changes
Status: Active » Needs review

Small patch with coding standards fixes on MR !3

LeoAlcci’s picture

LeoAlcci commented
Assigned: Unassigned » LeoAlcci

I'll review it!

LeoAlcci’s picture

LeoAlcci commented
Assigned: LeoAlcci » Unassigned

Good job @jmizarela, also I found a little phpcs issue and fixed it:

---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
16 | ERROR | [x] Case breaking statements must be followed by a single blank line
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------

Please kindly review it!

juancec’s picture

juancec commented
Assigned: Unassigned » juancec

Hi, I'll review it.

juancec’s picture

juancec commented
Assigned: juancec » Unassigned
Status: Needs review » Reviewed & tested by the community

Good job @jmizarela and @LeoAlcci. PHPCS issues have been fixed. Hence I move it to RTBC.

clemens.tolboom made their first commit to this issue’s fork.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

I merged the PR but I guess I should have used the credit message from d.o. within the squash and edit commit message.gitlab. sorry about that :-(

Issue #3313528 by jmizarela, LeoAlcci, clemens.tolboom: Drupal coding standards

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.