Closed (won't fix)
Project:
CKEditor Div Manager
Version:
2.0.0
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Oct 2022 at 13:42 UTC
Updated:
3 Oct 2022 at 19:05 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
aaronpinero commentedI tested this change by manually updating the .info.yml file, then uninstalling the ckeditor4 contrib module. The div manager widget seems to work fine.
I tried generating a simple patch for this change, but I could not get the patch to apply via composer. This is the first time I've had this problem so I'm not sure what the issue is. Is it possible that patches to .info.yml files are not allowed?
Comment #3
aaronpinero commentedComment #4
aaronpinero commentedI've attached the patch I was trying to use; this is the simple edit I think is needed, but the patch will not apply through composer.
Comment #5
berdirNot the maintainer, but this change is intended. editor and ckeditor modules are not the same thing, this does depend on ckeditor.
See https://www.drupal.org/project/better_normalizers/issues/3294780#comment... for a workaround to stay on the core version, but switching to contrib is intended.
Comment #6
aaronpinero commented@Berdir I am confused by your reply. The module information page (and the README for this module) state that the module depends on *core* CKEditor. There is no indication *contrib* CKEditor would be installed as a dependency with this module, and it was only when updating my website to PHP8 that I discovered contrib CKEditor was present.
If this module is supposed to depend on *contrib* CKEditor, the module's documentation is misleading. It's also an incredibly curious choice since CKEditor 4 is soon to be deprecated.
Also, what then is the solution for users who want to use this plugin with CKEditor 5 (in core)? Is there going to be a separate project available for users who (understandably) don't want to install an unnecessary contributed module?
Comment #7
berdirthe ckeditor *module* is deprecated and moved to contrib. the contrib version is identical to what is in core. Once you update to 9.5, you'll also see a deprecation from the core module. see https://www.drupal.org/docs/core-modules-and-themes/deprecated-and-obsol....
whether or not that module will become ckeditor 5 compatible or not I don't know but ckeditor5 support is in a new module called ckeditor5 in core that you need to enable instead.
Comment #8
berdiralso, I'm not seeing any indication that https://ckeditor.com/cke4/addon/div exists at all for ckeditor5, it's a completely different product, so maybe that's built in or something.