The social_pwa.info.yml file contains the following line.

core_version_requirement: ^8 || ^9

The activity_send_push.info.yml file contains the following lines.

core: 8.x
core_version_requirement: ^8 || ^9

Since this branch is using semantic version, it won't be compatible with any Drupal version earlier than drupal 8.8.3. The value for core_version_requirement needs to be updated to core_version_requirement: ^8.9 || ^9.
Changing the value for core_version_requirement also requires to remove the core key.

The same change isn't necessary for the 8.x-1.x branch, since at least a branch needs to be compatible with every Drupal 8 version (despite they aren't supported).

Comments

apaderno created an issue. See original summary.

avpaderno’s picture

Status: Active » Needs review
StatusFileSize
new1.01 KB

It would preferable to first commit the patch for #3256169: Use namespaced dependencies.

imustakim’s picture

I will review it.

imustakim’s picture

Assigned: Unassigned » imustakim
imustakim’s picture

Assigned: imustakim » Unassigned
Status: Needs review » Reviewed & tested by the community

Patch #2 works fine.

robertragas’s picture

By now this has been changed to 9 || 10 so this change is not needed anymore, so setting it to fixed and will credit you both for the work.

robertragas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.