Problem/Motivation

Discovered whilst working on #3313038: Fix PHPStorm "Undefined Class" inspection failures

Since phpunit 7.0 method PHPUnit\Framework\TestCase::prepareTemplate has been removed.
(See https://phpunit.de/announcements/phpunit-7.html, last bullet-point under heading "Backwards Compatibility Issues")

We still (try to) extend that method in \Drupal\KernelTests\KernelTestBase::prepareTemplate.

Steps to reproduce

Proposed resolution

Remove (what seems now to be a redundant) method \Drupal\KernelTests\KernelTestBase::prepareTemplate

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3313021-10.x-4.patch1.81 KBspokje
#2 3313021-2.patch1.17 KBspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3313021-2.patch1.17 KB
spokje’s picture

spokje
Primary language Dutch
commented
Assigned: Unassigned » spokje
Status: Active » Needs work
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3313021-10.x-4.patch1.81 KB
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Reviewed & tested by the community

Less cruft FTW

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned

Thanks @mondrake for the drive-by RTBC :)

spokje’s picture

spokje
Primary language Dutch
commented

(Started a re-test on 10.0.x so the bi-daily auto-retest doesn't test the 9.5.x patch on 10.0.x)

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#3313038: Fix PHPStorm "Undefined Class" inspection failures
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 5564aee8ce to 10.1.x and 0ac1488b75 to 10.0.x. Thanks!
Committed c0bc0eb and pushed to 9.5.x. Thanks!

Less code FTW - backported to 9.5.x as this is a test only change.

  • alexpott committed 5564aee on 10.1.x 
    Issue #3313021 by Spokje: Remove obsolete \Drupal\KernelTests\...

  • alexpott committed 0ac1488 on 10.0.x 
    Issue #3313021 by Spokje: Remove obsolete \Drupal\KernelTests\...

  • alexpott committed c0bc0eb on 9.5.x 
    Issue #3313021 by Spokje: Remove obsolete \Drupal\KernelTests\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.