With the commerce store filter query parameter, I need to reload the page to get the correct currency. Potentially as it kicks in too late in the process? I saw the code in the event subscriber mentioned it needed to have a lower priority in order for the route to complete the build...

I've just moved the request logic into the store resolver itself. Personally I'd like it to be in here just so I can prioritise my store resolvers accordingly, however this may not be the correct way of doing things! :)

PS Thanks for the great module!!

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

littlepixiez created an issue. See original summary.

arunkumark’s picture

Status: Active » Needs review
arunkumark’s picture

Status: Needs review » Reviewed & tested by the community

Patch looks fine. Moving to the RTBC.

arunkumark’s picture

Status: Reviewed & tested by the community » Fixed

It was merged into the dev branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.