FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\commerce_giftcard_mail\commerce_giftcard_mail.module
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 6 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
2 | ERROR | [ ] Missing short description in doc comment
6 | WARNING | [x] Unused use statement
10 | ERROR | [x] There must be no blank lines after the function comment
27 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
33 | ERROR | [ ] The array declaration extends to column 195 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\commerce_giftcard_mail\README.md
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 124 characters
9 | WARNING | Line exceeds 80 characters; contains 226 characters
13 | WARNING | Line exceeds 80 characters; contains 139 characters
-----------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\commerce_giftcard_mail\src\Plugin\Commerce\EmailEvent\GiftcardActivated.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#6 Coding-standards-resolved-3312009-6.patch3.46 KBurvashi_vora
#3 3312009-3.patch903 bytes_pratik_
#2 standard-coding-issue-3312009-2.patch2.96 KBakshay.kelotra

Issue fork commerce_giftcard_mail-3312009

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

akshay.kelotra created an issue. See original summary.

akshay.kelotra’s picture

akshay.kelotra commented
Assigned: akshay.kelotra » Unassigned
Category: Task » Bug report
Status: Active » Needs review
StatusFileSize
new standard-coding-issue-3312009-2.patch2.96 KB

I have fixed this issue and providing patch.

_pratik_’s picture

_pratik_
Primary language English
Location Indore
commented
StatusFileSize
new 3312009-3.patch903 bytes

Hey @akshay,
Try this for commerce_giftcard_mail.module file.

urvashi_vora’s picture

urvashi_vora commented
Assigned: Unassigned » urvashi_vora

Hi,

I will review this.

urvashi_vora’s picture

urvashi_vora commented
Status: Needs review » Needs work

Hi @pratik_specbee,

After applying your patch, still module file contains coding standard issues.

FILE: ...dules/contrib/commerce_giftcard_mail-3312009/commerce_giftcard_mail.module
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 12 | ERROR | [x] There must be no blank lines after the function comment
 35 | ERROR | [ ] The array declaration extends to column 195 (the limit is
    |       |     80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Thus, moving it to needs work. And I am working on it

urvashi_vora’s picture

urvashi_vora commented
Assigned: urvashi_vora » Unassigned
Status: Needs work » Needs review
StatusFileSize
new Coding-standards-resolved-3312009-6.patch3.46 KB

Hi,

I resolved all issues and warnings, please review this patch.

Thanks

cinarb’s picture

cinarb commented
Assigned: Unassigned » cinarb

Hi Ill review it

cinarb’s picture

cinarb commented
Assigned: cinarb » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi @urvashi_vora , Your patch was applied cleanly. All of the issues are fixed. Ill move this issue to RTBC. =)

kensae opened merge request !2

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work 
 dependencies:
-  - commerce_giftcard
-  - commerce_email
+  - drupal:commerce_giftcard
+  - drupal:commerce_email

Those aren't Drupal core modules.

  • kensae committed 3ec0454 on 1.0.x 
    Issue #3312009: Standard coding issue
kensae’s picture

kensae commented

Thank you all for contributing, I've applied the patch in the latest dev version.
I also took care of apaderno's comment who states correctly that the dependencies are non-core dependecies.

kensae’s picture

kensae commented
Status: Needs work » Fixed
kensae’s picture

kensae commented
Status: Fixed » Closed (fixed)
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

I meant that these dependencies are wrong, since these aren't Drupal core modules.

  - drupal:commerce_giftcard
  - drupal:commerce_email
kensae’s picture

kensae commented

I changed this in the 1.x-dev with
- commerce_giftcard:commerce_giftcard
- commerce_email:commerce_email

kensae closed merge request !2