phpcs --standard=Drupalpractice issue [#3312006]

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\translatable_config_pages\src\Commands\TranslatableConfigPagesCommands.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
60 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\translatable_config_pages\src\Form\TranslatableConfigPagesTypeForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
91 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
98 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
99 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

Comment	File	Size	Author
#2	drupal-standard-practice-3312006-2.patch	5.07 KB	akshay.kelotra

Issue fork translatable_config_pages-3312006

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3312006-phpcs---standarddrupalpractice-issue changes, plain diff MR !1
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

27 September 2022 at 08:03

akshay.kelotra created an issue. See original summary.

Comment #2

akshay.kelotra commented 27 September 2022 at 08:37

Assigned:	akshay.kelotra	» Unassigned
Category:	Task	» Bug report
Status:	Active	» Needs review

Status	File	Size
new	drupal-standard-practice-3312006-2.patch	5.07 KB

I have fixed this issue and providing a patch.

Comment #3

urvashi_vora commented 27 September 2022 at 09:50

Assigned:

Unassigned

» urvashi_vora

Hi,

I will review this.

Comment #4

urvashi_vora commented 27 September 2022 at 11:18

Hi,

I reviewed the patch, here is the output.

urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib/translatable_config_pages-3312006$ git apply -v drupal-standard-practice-3312006-2.patch
Checking patch src/Commands/TranslatableConfigPagesCommands.php...
Checking patch src/Form/TranslatableConfigPagesTypeForm.php...
Checking patch src/TranslatableConfigPagesAccessControlHandler.php...
Checking patch src/TranslatableConfigPagesTypeListBuilder.php...
Applied patch src/Commands/TranslatableConfigPagesCommands.php cleanly.
Applied patch src/Form/TranslatableConfigPagesTypeForm.php cleanly.
Applied patch src/TranslatableConfigPagesAccessControlHandler.php cleanly.
Applied patch src/TranslatableConfigPagesTypeListBuilder.php cleanly.
urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib/translatable_config_pages-3312006
urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib$