Fix classes in body tag

Thanks @Anchal_gupta, but it looks like @pratik_specbee is working on it?

Also, your patch doesn't work (it is missing a #), it doesn't fix all white-spaces, nor the bg- issue.

Thanks @pratik_specbee! That looks like it takes care of the issues and cleans it up.

There's a small detail, when you enable a background, an extra white-space is added:
<body class="toolbar-tray-open toolbar-horizontal toolbar-fixed toolbar-loading user-logged-in path-frontpage bg-dark d-flex flex-column h-100">

Looks good @pratik, there are only one space now, both with or without background enabled.

It wasn't part of the initial issue, but I just took a look at the source, and stumbled over another instance of extra white-spaces, coming from templates/layout/page.html.twig:

<footer class="mt-auto footer-dark text-light bg-secondary">

Would it be possible for you to take a look at it as well?

Thanks! It almost works, but if I enable "Footer options" > "Footer background", I get this:

<footer class="mt-auto bg-primary">

Thanks @Shyam_Bhatt, it works sort of, but I still see this: <footer class="mt-auto "> and <footer class="mt-auto bg-secondary">.

Sure, that's also what it says in my file ... but I still get the spacing.

It's probably best to aim for a single unified patch, which fixes both body and footer tag at the same time.

Thanks for the fresh release of 2.0.1 @VladimirAus, but it still has the spacing issue. Also, it happens both in the default theme, but also sub-themes.

I agree, it is not critical, but can be solved, and there was progress here solving that. Also, there is a "half" class, displayed as bg- which could be an issue, and should be fixed in my opinion.

Thanks for the tip about the 2.0.2 release. Perhaps a short note could be added on https://www.drupal.org/project/bootstrap5/releases/2.0.2 to explain the reason why it was released?

Sorry @Shyam_Bhatt, your patch in #14 is indeed unified, including the fix for the body, and adding a solution for the footer, which works sort of: There are still spaces in the footer, just less ...

The body, which was my main concern was fixed by @_pratik_, so thanks for that.

The issue is solved, so I am changing Status and lowering Priority, since nothing is broken, and it's more a nice-to-have than need-to-have.

I have been thinking some more about this, and maybe it's better to deal with getting the classes right in the preprocess stage, rather than Twig? Here is a patch with an attempt. Also, I am removing the footer task for now, footer and navbar can always be fixed in another issue.

@Shyam_Bhatt: A patch in an issue needs to go through the steps required, with thorough review, and then changing status to "Reviewed and tested by the community", if it looks good and works well, the code guidelines are followed, etc.

For more, see Review a patch or merge request.

Thanks, but the two patches in #12 and #14 are no longer valid. The patch for review is #23, and the Merge Request is https://git.drupalcode.org/project/bootstrap5/-/merge_requests/17

Thanks @Shyam_Bhatt. Perhaps you can also check if bg-classes are added correctly, if Body theme and Body background options are enabled, and share your observations here?

I have created #3317503: Check and fix classes in footer and navbar, if needed to check if other tags such as footer and navbar have the same issue, to maybe also move the logic to bootstrap5.theme file.

This is the Merge Request which was reviewed by @Shyam_Bhatt:
https://git.drupalcode.org/project/bootstrap5/-/merge_requests/17

It looks like something else was committed ...

@Shyam_Bhatt: Right, and I created #3317503: Check and fix classes in footer and navbar, if needed, as I mentioned in #31. Or do you mean something else?