FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\qrcode\qrcode.install
----------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\qrcode\qrcode.module
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\qrcode\README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
14 | WARNING | Line exceeds 80 characters; contains 156 characters
26 | WARNING | Line exceeds 80 characters; contains 99 characters
----------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\qrcode\src\Controller\QRCodeController.php
---------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\qrcode\src\Entity\QRCode.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\qrcode\src\EventSubscriber\QRCodeRequestSubscriber.php
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\qrcode\src\Form\QRCodeDeleteForm.php
---------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\qrcode\src\Form\QRCodeForm.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\qrcode\src\Form\QRCodeSettingsForm.php
-----------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\qrcode\src\Plugin\views\field\QRCodeThumbnailField.php
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\qrcode\src\QRCodeInterface.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\qrcode\src\QRCodeRepository.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\qrcode\src\QRCodeStorageSchema.php
-------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\qrcode\src\QRCodeViewsData.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------

CommentFileSizeAuthor
#5 drupal-standard-coding-issue-3311815-5.patch4.67 KBArturo-q
#2 drupal-standard-coding-issue-3311815-2.patch1.08 KBakshay.kelotra

Issue fork qrcode-3311815

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

akshay.kelotra created an issue. See original summary.

akshay.kelotra’s picture

akshay.kelotra commented
Assigned: akshay.kelotra » Unassigned
Category: Task » Bug report
Status: Active » Needs review
StatusFileSize
new drupal-standard-coding-issue-3311815-2.patch1.08 KB

I have fixed this issue and providing a patch.

Arturo-q’s picture

Arturo-q commented
Assigned: Unassigned » Arturo-q

Hello, I will review it!.

Arturo-q’s picture

Arturo-q commented
Status: Needs review » Needs work

The Patch #2 solve some CS, but I found more on QRCodeViewsData.php, QRCodeForm.php and QRCodeSettingsForm.php
Changing status to needs work, and I will be working on it.

Arturo-q’s picture

Arturo-q commented
Assigned: Arturo-q » Unassigned
Status: Needs work » Needs review
StatusFileSize
new drupal-standard-coding-issue-3311815-5.patch4.67 KB

I've solved all the CS errors, but I'm not sure if
$this->configFactory->get('qrcode.settings')->get('enable_direct_urls') on QRCodeForm.php
Is the dependency injection way there
Please review.

urvashi_vora’s picture

urvashi_vora commented
Assigned: Unassigned » urvashi_vora

Hi,

I will review this

urvashi_vora’s picture

urvashi_vora commented

Hi,

I applied your patch. It applied clenly.

urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib/qrcode-3311815$ git apply -v drupal-standard-coding-issue-3311815-5.patch
Checking patch README.md...
Checking patch qrcode.install...
Checking patch src/Form/QRCodeForm.php...
Checking patch src/Form/QRCodeSettingsForm.php...
Checking patch src/QRCodeViewsData.php...
Applied patch README.md cleanly.
Applied patch qrcode.install cleanly.
Applied patch src/Form/QRCodeForm.php cleanly.
Applied patch src/Form/QRCodeSettingsForm.php cleanly.
Applied patch src/QRCodeViewsData.php cleanly.

Thanks for the patch.

urvashi_vora’s picture

urvashi_vora commented
Assigned: urvashi_vora » Unassigned
Status: Needs review » Reviewed & tested by the community

No errors found later. Moving it to RTBC.

urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig qrcode-3311815/
urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib$

  • eakroko committed 1b817cf3 on 1.0.x authored by Arturo1007 
    Issue #3311815 by akshay.kelotra, Arturo1007, urvashi_vora: Drupal...
eakroko’s picture

eakroko commented
Status: Reviewed & tested by the community » Fixed
eakroko’s picture

eakroko commented
Status: Fixed » Closed (fixed)