Problem/Motivation

  • Extend the SPA functionality to allow flexible configuration of initial form values.

Issue fork cloud-3311750

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1344

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Extend SPA functionality to allow flexible configuration of form initial values » Refactor to allow flexible configuration of initial form values in SPA
Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the refactoring. Can you please check the following coding standard error? Thanks!

FILE: ...d/modules/cloud_dashboard/cloud_dashboard/src/service/storage.ts
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 21 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 49.14 secs; Memory: 58.01MB
ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I fixed that coding standard error. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for fixing the coding standard error. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed c5a0f10 on 5.x authored by Ryo Yamashita 
    Issue #3311750 by Ryo Yamashita, yas: Refactor to allow flexible...

  • yas committed 9bfc601 on 4.x 
    Issue #3311750 by Ryo Yamashita, yas: Refactor to allow flexible...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.