FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\civicrm_afform_block\civicrm_afform_block.module
---------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
21 | WARNING | [ ] Line exceeds 80 characters; contains 103 characters
23 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\civicrm_afform_block\readme.md
---------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 146 characters
9 | WARNING | Line exceeds 80 characters; contains 182 characters
15 | WARNING | Line exceeds 80 characters; contains 124 characters
---------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\civicrm_afform_block\src\Plugin\Block\CivicrmAfformBlock.php
---------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
---------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
33 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found
34 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found
40 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
64 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found
65 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found
69 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#2 line-exceeds-3311596-2.patch3.57 KBakshay.kelotra

Issue fork civicrm_afform_block-3311596

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

akshay.kelotra created an issue. See original summary.

akshay.kelotra’s picture

akshay.kelotra commented
Assigned: akshay.kelotra » Unassigned
Category: Task » Bug report
Status: Active » Needs review
StatusFileSize
new line-exceeds-3311596-2.patch3.57 KB

I have fixed this issue and providing a patch.

urvashi_vora made their first commit to this issue’s fork.

urvashi_vora’s picture

urvashi_vora commented
Assigned: Unassigned » urvashi_vora

Hi,

I am reviewing this.

urvashi_vora’s picture

urvashi_vora commented
Assigned: urvashi_vora » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi,

I reviewed the patch. It was applied cleanly and no issues were found later.

urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib/civicrm_afform_block-3311596$ git apply -v line-exceeds-3311596-2.patch
Checking patch civicrm_afform_block.module...
Checking patch readme.md...
Checking patch src/Plugin/Block/CivicrmAfformBlock.php...
Applied patch civicrm_afform_block.module cleanly.
Applied patch readme.md cleanly.
Applied patch src/Plugin/Block/CivicrmAfformBlock.php cleanly.

Moving this to RTBC.

mmjvb’s picture

mmjvb commented

@urvash_vora The way you contributed can be considered as gaming the credit system. It is not considered valuable due to the verbosity of things that don't really matter.

- Please refrain from creating an issue fork and assigning to the issue when reviewing.
- There is no need to review the patching process, unless it fails. Far too verbose in this case. Suitable when you do the right things but they go wrong.
- The one-liner about no problems found is not enough to RTBC. You need to elaborate on the searching for problems. Specify test scenario's, the results and your assessment of them. Only RTBC when your coverage is enough.
Are the errors/warnings fixed?

urvashi_vora’s picture

urvashi_vora commented

Hi @mmjvb,

This is an open source platform and we as Druplers try to contribute to it. And No one is asking for credit from anyone here. Even when you work for hours on certain issues, you do not get any credit for that when the issue gets fixed. But what matters is the fixing of issue. We here, on the community are trying to fix as much issues as we can.

And for this issue, if you can check I have clearly added the commands and output that "I" executed for testing and also mentioned that "No issues were found later". I hope that is readable.

Anyways, thanks for taking out time and giving a feedback here.

So no personal grudges friend. Have a good day ahead.

mmjvb’s picture

mmjvb commented

@urvashi_vora Suggest you have a look at https://www.drupal.org/forum/general/general-discussion/2022-09-27/is-it... as it puts my response to you in perspective.

Sounds like we disagree on how to test and report findings. Had no problem with understanding your report, just disagree on verbosity in the wrong area. Due to that consider it of low value, very easy to turn into higher value. It is a matter of getting across what you did. The things that matter were to abstract, the things that don't matter too verbose.

As mentioned in the issue I linked to as maintainer I would credit you both.

There is an initiative to better formulate what is expected in these situations: https://www.drupal.org/project/drupalorg/issues/3308679

urvashi_vora’s picture

urvashi_vora commented

Thanks

elisseck’s picture

elisseck commented

credited and fixed.

elisseck’s picture

elisseck commented
Category: Bug report » Task
Priority: Normal » Minor
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.