Fix the issues reported by phpcs [#3310843]

Problem/Motivation

Fix this issues reported by phpcs.

Steps to reproduce:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig .

Errors:

FILE: /Users/specbee/Sites/Projects/twitter_feeds/twitter_feeds.libraries.yml
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
 14 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/twitter_feeds/css/custom.css
----------------------------------------------------------------------------
FOUND 20 ERRORS AFFECTING 11 LINES
----------------------------------------------------------------------------
  2 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  3 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  4 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  5 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  6 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  9 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 12 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 13 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 15 | ERROR | [x] Multiple selectors should each be on a single line
 16 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 17 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/twitter_feeds/twitter_feeds.module
---------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 6 WARNINGS AFFECTING 10 LINES
---------------------------------------------------------------------------------------------
  8 | WARNING | [x] Unused use statement
  9 | WARNING | [x] Unused use statement
 11 | WARNING | [x] Unused use statement
 12 | WARNING | [x] Unused use statement
 21 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 4
 22 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 4
 23 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 4
 24 | ERROR   | [x] Case breaking statement indented incorrectly; expected 6 spaces, found 4
 36 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 39 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/twitter_feeds/twitter_feeds.info.yml
------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------
 7 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/twitter_feeds/templates/twitter-feeds.html.twig
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 45 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/twitter_feeds/templates/twitter-follow-button.html.twig
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
 17 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/twitter_feeds/src/Plugin/Block/TwitterFollowButtonBlock.php
-------------------------------------------------------------------------------------------------------------
FOUND 18 ERRORS AND 4 WARNINGS AFFECTING 11 LINES
-------------------------------------------------------------------------------------------------------------
  47 | ERROR   | [x] Expected 1 space before "??"; 0 found
  47 | ERROR   | [x] Expected 1 space after "??"; 0 found
  50 | WARNING | [x] A comma should follow the last multiline array item. Found: true
  50 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  56 | ERROR   | [x] Expected 1 space before "??"; 0 found
  56 | ERROR   | [x] Expected 1 space after "??"; 0 found
  56 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  58 | WARNING | [x] A comma should follow the last multiline array item. Found: )
  62 | ERROR   | [x] Expected 1 blank line after function; 2 found
  70 | ERROR   | [x] Expected 1 space after IF keyword; 0 found
  87 | ERROR   | [x] Short array syntax must be used to define arrays
  88 | ERROR   | [x] Expected 1 space before "??"; 0 found
  88 | ERROR   | [x] Expected 1 space after "??"; 0 found
  89 | ERROR   | [x] Expected 1 space before "?"; 0 found
  89 | ERROR   | [x] Expected 1 space after "?"; 0 found
  89 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  89 | ERROR   | [x] Expected 1 space before ":"; 0 found
  89 | ERROR   | [x] Expected 1 space after ":"; 0 found
  89 | WARNING | [x] A comma should follow the last multiline array item. Found: false
  89 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  95 | WARNING | [x] A comma should follow the last multiline array item. Found: $twitter_follow_button_data
 104 | ERROR   | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 22 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/twitter_feeds/src/Plugin/Block/TwitterFeedsBlock.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 32 ERRORS AND 13 WARNINGS AFFECTING 29 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
  47 | ERROR   | [x] Expected 1 space before "??"; 0 found
  47 | ERROR   | [x] Expected 1 space after "??"; 0 found
  50 | WARNING | [x] A comma should follow the last multiline array item. Found: true
  50 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  56 | ERROR   | [x] Expected 1 space before "??"; 0 found
  56 | ERROR   | [x] Expected 1 space after "??"; 0 found
  58 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes instead
  58 | WARNING | [x] A comma should follow the last multiline array item. Found: )
  66 | ERROR   | [x] Expected 1 space before "??"; 0 found
  66 | ERROR   | [x] Expected 1 space after "??"; 0 found
  69 | WARNING | [x] A comma should follow the last multiline array item. Found: true
  69 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  75 | ERROR   | [x] Expected 1 space before "??"; 0 found
  75 | ERROR   | [x] Expected 1 space after "??"; 0 found
  82 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  83 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  84 | ERROR   | [x] Short array syntax must be used to define arrays
  85 | WARNING | [ ] #options values usually have to run through t() for translation
  86 | WARNING | [ ] #options values usually have to run through t() for translation
  87 | WARNING | [ ] #options values usually have to run through t() for translation
  89 | ERROR   | [x] Expected 1 space before "??"; 0 found
  89 | ERROR   | [x] Expected 1 space after "??"; 0 found
  92 | ERROR   | [x] Short array syntax must be used to define arrays
  94 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  95 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  96 | ERROR   | [x] Expected 1 space before "??"; 0 found
  96 | ERROR   | [x] Expected 1 space after "??"; 0 found
  96 | WARNING | [x] A comma should follow the last multiline array item. Found: ''
 100 | ERROR   | [x] Expected 1 blank line after function; 2 found
 108 | ERROR   | [x] Expected 1 space after IF keyword; 0 found
 133 | ERROR   | [x] Short array syntax must be used to define arrays
 134 | ERROR   | [x] Expected 1 space before "??"; 0 found
 134 | ERROR   | [x] Expected 1 space after "??"; 0 found
 135 | ERROR   | [x] Expected 1 space before "??"; 0 found
 135 | ERROR   | [x] Expected 1 space after "??"; 0 found
 136 | ERROR   | [x] Expected 1 space before "??"; 0 found
 136 | ERROR   | [x] Expected 1 space after "??"; 0 found
 137 | ERROR   | [x] Expected 1 space before "??"; 0 found
 137 | ERROR   | [x] Expected 1 space after "??"; 0 found
 138 | ERROR   | [x] Expected 1 space before "??"; 0 found
 138 | ERROR   | [x] Expected 1 space after "??"; 0 found
 139 | ERROR   | [x] Expected 1 space before "??"; 0 found
 139 | ERROR   | [x] Expected 1 space after "??"; 0 found
 145 | WARNING | [x] A comma should follow the last multiline array item. Found: $twitter_feeds_data
 153 | ERROR   | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 37 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

Comment	File	Size	Author
#24	3310843-20-after.png	681.35 KB	rajneeshb
#24	3310843-20-before.png	526.14 KB	rajneeshb
#20	3310843-20.patch	12.22 KB	imustakim
#5	interdiff_04-05.txt	2.45 KB	lucassc
#5	3310843-05.patch	14.67 KB	lucassc
#5	phpcs_errors_left.txt	3.5 KB	lucassc
#4	twitter_feeds-3310843-3.patch	12.18 KB	mauryarahul11
#2	phpcs-issue-3310843-2.patch	1.61 KB	akshay.kelotra

Issue fork twitter_feeds-3310843

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3310843- changes, plain diff MR !3 / changes, plain diff MR !2
Check out this branch for the first time

Check out existing branch, if you already have it locally

1 hidden branch

master

changes, plain diff MR !1

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

21 September 2022 at 10:27

akshay.kelotra created an issue. See original summary.

Status	File	Size
new	phpcs-issue-3310843-2.patch	1.61 KB

Comment #3

mauryarahul11

Mumbai, India

commented 21 September 2022 at 11:04

Assigned:	Unassigned	» mauryarahul11
Status:	Needs review	» Needs work

Thanks @akshay.kelotra for your patch, i can see you only fixed t() function warnings and after applying your patch i got multiple warnings and error related to code standard. I will going to fix it and create new patch.

Comment #4

mauryarahul11

Mumbai, India

commented 21 September 2022 at 11:11

Assigned:	mauryarahul11	» Unassigned
Status:	Needs work	» Needs review

Status	File	Size
new	twitter_feeds-3310843-3.patch	12.18 KB

Attaching the patch which fixes all the code standard errors and warning given by phpcs.

Comment #5

lucassc

he/him

Portuguese, Brazil

Rio de Janeiro

commented 22 September 2022 at 17:47

Status	File	Size
new	phpcs_errors_left.txt	3.5 KB
new	3310843-05.patch	14.67 KB
new	interdiff_04-05.txt	2.45 KB

Hi!

I applied patch in #4 for drupal 9.4.5 and looks good! Changes in the code makes sense and phpcs returned errors/warning for just 2 js files.

In the 1st case it's about indentation and the other file is minified.

I'm uploading the phpcs output, a new patch to fix the indentation and the interdiff.

Comment #6

WagnerMelo commented 22 September 2022 at 21:15

Assigned:

Unassigned

» WagnerMelo

Hello, i'll review it. XD

Comment #7

WagnerMelo commented 26 September 2022 at 12:27

Assigned:	WagnerMelo	» Unassigned
Status:	Needs review	» Reviewed & tested by the community

Hello, i reviewed this issue, and all errors related with Drupal Practice, are solved. I tested file per file, and after ran de phpcs code.
So i'll move this issue to RTBC.

Comment #8

sujan shrestha commented 1 December 2022 at 14:35

Comment #9

sujan shrestha commented 1 December 2022 at 14:36

Comment #10

1 December 2022 at 14:41

sujan.shrestha opened merge request !1

Comment #11

1 December 2022 at 14:47

sujan.shrestha opened merge request !2

Comment #12

1 December 2022 at 15:01

sujan.shrestha closed merge request !2

Comment #13

1 December 2022 at 15:01

sujan.shrestha closed merge request !1

Comment #14

1 December 2022 at 15:01

sujan.shrestha opened merge request !3

Comment #15

sujan shrestha commented 1 December 2022 at 15:06

Comment #16

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 3 March 2023 at 15:33

Status:	Reviewed & tested by the community	» Needs work
Issue tags:	-, -Novice	+Coding standards, +Needs issue summary update

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, report which command has been used, which arguments have been used, and which report that command shown.