Problem/Motivation

Hello project maintainers,

This issue is to help make this module compatible with Drupal 10.

Patches will be added to this issue that remove Drupal 10 deprecated API uses.

Remaining tasks

------ ----------------------------------------------------------------------------
Line migrate_devel/migrate_devel.drush.inc
------ ----------------------------------------------------------------------------
56 Call to deprecated function drush_log()..
------ ----------------------------------------------------------------------------

------ ----------------------------------------------------------------------------
Line migrate_devel/migrate_devel.drush.inc
------ ----------------------------------------------------------------------------
74 Call to deprecated function drush_log()..
------ ----------------------------------------------------------------------------

------ ----------------------------------------------------------------------------
Line migrate_devel/migrate_devel.drush.inc
------ ----------------------------------------------------------------------------
79 Call to deprecated function drush_log()..
------ ----------------------------------------------------------------------------

------ ----------------------------------------------------------------------------
Line migrate_devel/migrate_devel.drush.inc
------ ----------------------------------------------------------------------------
110 Call to deprecated function drush_log()..
------ ----------------------------------------------------------------------------

------ ----------------------------------------------------------------------------
Line migrate_devel/migrate_devel.info.yml
------ ----------------------------------------------------------------------------
0 Value of core_version_requirement: ^8 || ^9 is not compatible with the next major version of Drupal core. See
https://drupal.org/node/3070687..
------ ----------------------------------------------------------------------------

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Adarshsri786 created an issue. See original summary.

adarshsri786’s picture

Assigned: adarshsri786 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new1.61 KB

Hi,

Added a patch for the same. Please review.

Thanks.

adarshsri786’s picture

Hi,

Added a patch for the same. Please review.

Thanks.

j-vee’s picture

Status: Needs review » Reviewed & tested by the community

Tested & working fine. Can this be merged now that D10 was released? Thanks :-)

steinmb’s picture

Bumping this. Anyone feel for pushing the D10 support?

pcate’s picture

+1 RTBC. The patch applies cleanly and adding the required Drupal 10 compatability.

andrew.wang’s picture

+1. Kindly requesting a tagged release :-)

volodymyr.umanets made their first commit to this issue’s fork.

jackg102’s picture

I will add support for making a D10 release -- we are doing our upgrade and it appears folks have tested this above in the thread.

theodorosploumis’s picture

I am waiting for this also. We have a 10.x website using this patch and works fine.
Thanks.

bob.hinrichs’s picture

Hope for a release soon! Thanks

joegraduate’s picture

Patch #2 is working for us but is complicated to use without a D10 compatible release being available.

@aczietlow, @andrewmacpherson, @Derimagia any chance this could get a committed and a new release tagged? Are you seeking new co-maintainers?

penaccaratogarciagaregnani-at-reserv made their first commit to this issue’s fork.

c-logemann’s picture

@joegraduate Using composer-drupal-lenient makes it easy patch in D10.

inversed’s picture

That composer plugin solved it for me as well.

batigolix’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for providing and reviewing the patch.

I created a release 8.x-2.0 that is D10 compatible.

@joegraduate: yes this module needs maintenance (#3366042: Migrate Devel appears to be unsupported). Let me know if you are able to help with this.

jackfoust’s picture

For D10, doesn't core: 8.x need removed?

The 'core_version_requirement' constraint (^9.5 || ^10) requires the 'core' key not be set in modules/composer/migrate_devel/migrate_devel.info.yml

solideogloria’s picture

Status: Fixed » Needs work

Yes. In order to be compatible with D10, you must remove core: 8.x.

batigolix’s picture

Status: Needs work » Fixed

Thanks!

I removed this and created a new release.

How can I see this error?

jackfoust’s picture

I got the error above when I ran a drush updb after I updated via composer.

nmangold’s picture

Status: Fixed » Needs review
StatusFileSize
new342 bytes

The correct key was not removed in the last release.

Added a patch that removes the core: 8.x.

jackfoust’s picture

@nmangold patch didn't apply for me, patches on info.yml can be tricky - typically need some extra line returns in there.

nmangold’s picture

StatusFileSize
new385 bytes

@jackfoust. I think the problem here is this feature branch is not updated, and does not contain the latest changes from the 8.x-2.x branch. Specifically, the core version requirement was changed to ^9.5 in https://git.drupalcode.org/project/migrate_devel/-/commit/725b66750e1e69....

Here is another patch that will apply cleanly to THIS branch, before it is updated.

If I had push access to the issue branch, I could have updated the branch myself.

batigolix’s picture

I probably made a mistake with the new release.

As far as I can see the line has now been removed from the info yml file in release 8.x-2.1

I tested this locally with composer.

Can you confirm this?

@nmangold let me know if you like to help maintaining the module.

nmangold’s picture

@batigolix Your last commit fixed the issue. https://git.drupalcode.org/project/migrate_devel/-/commit/4bf1ecc56d1a07...

It looks like you did that at the same time I was creating this patch. I missed your comment.

I think this can be marked as fixed.

nmangold’s picture

I updated this branch from 2.x, and pushed. So, this branch has the change, and everything is clear.

nmangold’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.