Problem/Motivation
Hello project maintainers,
This issue is to help make this module compatible with Drupal 10.
Patches will be added to this issue that remove Drupal 10 deprecated API uses.
Remaining tasks
------ ----------------------------------------------------------------------------
Line migrate_devel/migrate_devel.drush.inc
------ ----------------------------------------------------------------------------
56 Call to deprecated function drush_log()..
------ ----------------------------------------------------------------------------
------ ----------------------------------------------------------------------------
Line migrate_devel/migrate_devel.drush.inc
------ ----------------------------------------------------------------------------
74 Call to deprecated function drush_log()..
------ ----------------------------------------------------------------------------
------ ----------------------------------------------------------------------------
Line migrate_devel/migrate_devel.drush.inc
------ ----------------------------------------------------------------------------
79 Call to deprecated function drush_log()..
------ ----------------------------------------------------------------------------
------ ----------------------------------------------------------------------------
Line migrate_devel/migrate_devel.drush.inc
------ ----------------------------------------------------------------------------
110 Call to deprecated function drush_log()..
------ ----------------------------------------------------------------------------
------ ----------------------------------------------------------------------------
Line migrate_devel/migrate_devel.info.yml
------ ----------------------------------------------------------------------------
0 Value of core_version_requirement: ^8 || ^9 is not compatible with the next major version of Drupal core. See
https://drupal.org/node/3070687..
------ ----------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #26 | migrate_devel-D10_readiness-3310624-26.patch | 385 bytes | nmangold |
| #24 | migrate_devel-D10_readiness-3310624-22.patch | 342 bytes | nmangold |
| #2 | 3310624-D10-readiness-migrate_devel.patch | 1.61 KB | adarshsri786 |
Issue fork migrate_devel-3310624
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3310624-drupal-10-compatibility
compare
- 3310624-d10-readiness
changes, plain diff MR !2
Comments
Comment #2
adarshsri786 commentedHi,
Added a patch for the same. Please review.
Thanks.
Comment #3
adarshsri786 commentedHi,
Added a patch for the same. Please review.
Thanks.
Comment #4
j-vee commentedTested & working fine. Can this be merged now that D10 was released? Thanks :-)
Comment #5
steinmb commentedBumping this. Anyone feel for pushing the D10 support?
Comment #6
pcate commented+1 RTBC. The patch applies cleanly and adding the required Drupal 10 compatability.
Comment #7
andrew.wang commented+1. Kindly requesting a tagged release :-)
Comment #11
jackg102 commentedI will add support for making a D10 release -- we are doing our upgrade and it appears folks have tested this above in the thread.
Comment #12
theodorosploumisI am waiting for this also. We have a 10.x website using this patch and works fine.
Thanks.
Comment #13
bob.hinrichs commentedHope for a release soon! Thanks
Comment #14
joegraduatePatch #2 is working for us but is complicated to use without a D10 compatible release being available.
@aczietlow, @andrewmacpherson, @Derimagia any chance this could get a committed and a new release tagged? Are you seeking new co-maintainers?
Comment #16
c-logemann@joegraduate Using composer-drupal-lenient makes it easy patch in D10.
Comment #17
inversed commentedThat composer plugin solved it for me as well.
Comment #19
batigolixThanks for providing and reviewing the patch.
I created a release 8.x-2.0 that is D10 compatible.
@joegraduate: yes this module needs maintenance (#3366042: Migrate Devel appears to be unsupported). Let me know if you are able to help with this.
Comment #20
jackfoust commentedFor D10, doesn't
core: 8.xneed removed?The 'core_version_requirement' constraint (^9.5 || ^10) requires the 'core' key not be set in modules/composer/migrate_devel/migrate_devel.info.ymlComment #21
solideogloria commentedYes. In order to be compatible with D10, you must remove
core: 8.x.Comment #22
batigolixThanks!
I removed this and created a new release.
How can I see this error?
Comment #23
jackfoust commentedI got the error above when I ran a
drush updbafter I updated via composer.Comment #24
nmangold commentedThe correct key was not removed in the last release.
Added a patch that removes the
core: 8.x.Comment #25
jackfoust commented@nmangold patch didn't apply for me, patches on info.yml can be tricky - typically need some extra line returns in there.
Comment #26
nmangold commented@jackfoust. I think the problem here is this feature branch is not updated, and does not contain the latest changes from the 8.x-2.x branch. Specifically, the core version requirement was changed to ^9.5 in https://git.drupalcode.org/project/migrate_devel/-/commit/725b66750e1e69....
Here is another patch that will apply cleanly to THIS branch, before it is updated.
If I had push access to the issue branch, I could have updated the branch myself.
Comment #27
batigolixI probably made a mistake with the new release.
As far as I can see the line has now been removed from the info yml file in release 8.x-2.1
I tested this locally with composer.
Can you confirm this?
@nmangold let me know if you like to help maintaining the module.
Comment #28
nmangold commented@batigolix Your last commit fixed the issue. https://git.drupalcode.org/project/migrate_devel/-/commit/4bf1ecc56d1a07...
It looks like you did that at the same time I was creating this patch. I missed your comment.
I think this can be marked as fixed.
Comment #29
nmangold commentedI updated this branch from 2.x, and pushed. So, this branch has the change, and everything is clear.
Comment #30
nmangold commented