Problem/Motivation

Ideally this autocomplete functionality would work in webforms as well.

Steps to reproduce

Proposed resolution

Expose an address_autocomplete webform element.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 address_autocomplete-webform-integration-3310478-2.patch965 byteschrisolof

Issue fork address_autocomplete-3310478

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chrisolof created an issue. See original summary.

chrisolof’s picture

chrisolof
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new address_autocomplete-webform-integration-3310478-2.patch965 bytes

The attached patch adds the basic webform integration via a new "Advanced address with autocomplete" webform element.

chrisolof’s picture

chrisolof
he/him
Primary language English
commented
Assigned: chrisolof » Unassigned

geoffreyr made their first commit to this issue’s fork.

geoffreyr’s picture

geoffreyr commented

@chrisolof Looks good so far. I've created an issue fork and added your patch to it, plus a tiny change to add core/drupal.autocomplete as a library dependency, so ui_autocomplete isn't seen as null or undefined.

What I'd like to do next is write a crosswalk between xAL property names and each of the fields that we're autocompleting into. I'll keep the existing property mappings so current implementations don't change.

I've got a few more feature ideas, but they might be better off kept to other requests.

geoffreyr opened merge request !6

geoffreyr’s picture

geoffreyr commented

I've done a pass at the merge request. One thing that occurs to me is that we might want the crosswalk to be configurable, depending on the autocomplete service that's being used. Do you think we should make that a setting instead, with some sensible defaults?

vaish made their first commit to this issue’s fork.

vaish changed the visibility of the branch 3310478-webform-integration to hidden.

vaish opened merge request !9

vaish closed merge request !6

  • vaish committed fa3ed6fd on 1.0.x 
    Issue #3310478 by geoffreyr, vaish, chrisolof: Webform integration
vaish’s picture

vaish commented
Status: Needs review » Fixed

@geoffreyr I decided to merge patch from #2 because I've been using it for a along time in production while I'm not familiar with the seemingly unrelated changes you added to MR !6. Could you please open up new issue for your changes where you would explain which problem you are trying to solve.

geoffreyr’s picture

geoffreyr commented

@vaish Thanks, will do.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.