Problem/Motivation

  • Add the function to edit AWS Subnet in the SPA

Issue fork cloud-3310457

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie opened merge request !1320

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review

@yas, here's the patch for edit subnet support in SPA.

I also fixed the following two items:
- Fixed `setTagsInAws` so that it doesn't modify any tags that starts with `aws:`. Those are read-only tags set by AWS. If they are passed to be edited, an error will be thrown. This happens if you try to modify the tags of any Aws entity created by Cloud Formation.
- Fixed Internet Gateway/Transit Gateway/Carrier Gateway to pass Tag values to the entity correctly. Otherwise, any new tags will be ignored and not updated.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes

@baldwinloiue

Thank you for the patch including the fixes. It looks good.

@sekinet

What do you think?

Ryo Yamashita’s picture

Ryo Yamashita commented

@baldwinloiue @yas

This patch looks good to me, Thanks.

sekinet’s picture

sekinet commented
Status: Needs review » Reviewed & tested by the community

@baldwinloiue @yas

Thank you for fixing the bug. It looks good.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@ryo-yamashita @sekinet

Thank you for your review.

@baldwinlouie

I found the following coding standard violation. Can you please check it? Thanks

FILE: ...service_providers/aws_cloud/src/Controller/Ec2/ApiController.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 947 | ERROR | [x] Case breaking statements must be followed by a
     |       |     single blank line
----------------------------------------------------------------------
baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review

@yas, I've updated the patch to fix the coder error.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for the update. It looks good. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 704baca on 5.x authored by baldwinlouie 
    Issue #3310457 by baldwinlouie, yas, Ryo Yamashita, sekinet: Add the...

  • yas committed e3ecf12 on 4.x 
    Issue #3310457 by baldwinlouie, yas, Ryo Yamashita, sekinet: Add the...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.