Problem/Motivation

  • the plus button in the paragraphs browser is misaligned in the gin admin theme

Steps to reproduce

  • use gin as admin theme
  • open paragraphs browser an hover over the paragraphs shown in the browser -> you'll see that the + icon is not

Proposed resolution

  • fix CSS - remove margin and use transform for positioning

Issue fork paragraphs_ee-3310395

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

SteffenR created an issue. See original summary.

SteffenR opened merge request !9

steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
Assigned: steffenr » Unassigned
Status: Active » Needs review
stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Needs review » Needs work

Could you please also commit your changes to paragraphs_ee.categories.scss ;)

Q: does this fix affects the alignment of the button in other themes, too? Or is the fix specific to Gin?

steffenr’s picture

steffenr
Primary language German
Location Bremen
commented

Thx for mentioning. I've added the changes to the scss files.

The fix will work for all themes/ not only gin. The way of positioning is recommended: https://medium.com/front-end-weekly/absolute-centering-in-css-ea3a9d0ad72e

steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
Status: Needs work » Needs review
aschiwi’s picture

aschiwi commented
Status: Needs review » Reviewed & tested by the community

Thanks, this works for me. I tested in Firefox (Mac), Chrome (Windows 10) and Edge (Windows 10).

kubrick’s picture

kubrick commented

Can this get merged?

stborchert’s picture

stborchert
he/him
Primary language German
commented
Version: 2.0.x-dev » 2.1.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks. Committed to 2.1.x.

  • SteffenR authored 5352af09 on 2.1.x 
    Issue #3310395 by SteffenR, aschiwi: Paragraphs browser - plus button is...
stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

stBorchert closed merge request !9