Problem/Motivation
On issue #3267943: Add option to customize "do not show again" cookie expiration was created a new settings called "custom_cookie_expiration_time" and "enable_custom_cookie_expiration" and the default value of "default_cookie_expiration" is 10000 as you can see here: https://git.drupalcode.org/project/modal_page/-/blob/78de53aa1184c44b74a...
So if a site install the Modal project this variable "default_cookie_expiration" will be created with value 10000 but all the ~1200 sites that currently is already using Modal Page won't get default value because only updating will not set this value without hook update
Proposed resolution
Create a hook update to set the default value for "custom_cookie_expiration_time" and "enable_custom_cookie_expiration". Example: https://git.drupalcode.org/project/modal_page/-/blob/4.1.16/modal_page.i...
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork modal_page-3309844
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
renatog commentedComment #3
renatog commentedComment #4
sophiavs commentedHi, i'll try to work on this!
Comment #5
renatog commentedAwesome. Thank you so much @sophiavs
Comment #7
sophiavs commentedSorry, i misunderstood the meaning of the issue and it end up making me take so much time.
I created the hook update to set the configuration and set te enable custom cookie expiration as false for every modal.
Comment #8
sophiavs commentedComment #9
renatog commentedThanks a lot!
No problems, I wasn't clear in the Issue Summary, sorry for that
Comment #10
renatog commentedI've put a comment in the PR at #9
Only in the comment
Comment #11
lucasscComment #12
lucasscComment adjusted
Comment #13
renatog commentedMerged at https://git.drupalcode.org/project/modal_page/-/commit/947def691c62735cc...
Thank you so much @sophiavs and @lucassc