Problem/Motivation

  • Add the function to edit AWS Carrier Gateway in the SPA

Issue fork cloud-3308967

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie opened merge request !1293

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review

@yas, This is the patch for editing Carrier Gateway in SPA

ryo yamashita’s picture

ryo yamashita commented

@baldwinlouie @yas

This patch looks good to me. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for your review.

@baldwinlouie

I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@baldwinlouie

Can you please rebase the patch? Thanks!

baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review

@yas, just rebased the patch

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for rebasing the patch. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 843e7d0 on 5.x authored by baldwinlouie 
    Issue #3308967 by baldwinlouie, yas, Ryo Yamashita: Add the function to...

  • yas committed 833ec94 on 4.x 
    Issue #3308967 by baldwinlouie, yas, Ryo Yamashita: Add the function to...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

@baldwinlouie

I found the following coding violations after merging the patch. Can you please create the hotfix for them? Thanks

----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 1810 | ERROR | [x] Array indentation error, expected 10 spaces but
      |       |     found 8
 1811 | ERROR | [x] Array indentation error, expected 10 spaces but
      |       |     found 8
 1839 | ERROR | [x] Array indentation error, expected 10 spaces but
      |       |     found 8
 1840 | ERROR | [x] Array indentation error, expected 10 spaces but
      |       |     found 8
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...ers/aws_cloud/src/Service/AwsCloud/AwsCloudOperationsService.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 2282 | ERROR | [x] Array indentation error, expected 12 spaces but
      |       |     found 10
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 45.61 secs; Memory: 58MB

baldwinlouie opened merge request !1301

baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review

@yas, sorry about that. I've created a hotfix branch and checked in the syntax fixes.

Its weird because my local phpcs complained that there were too many spaces, which is why I deleted those spaces.

BTW, What is your coder command you are using? I'm using the following when doing local testing:

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,yml,yaml,twig

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for the update. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

We are using both --standard="Drupal" and --standard="DrupalPractice" option for phpcs.

  • phpcs --colors --standard="Drupal" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,yaml,twig,json,ts,tsx,feature
  • phpcs --colors --standard="DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,yaml,twig,json,ts,tsx,feature

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@baldwinlouie

Can you please rebase the patch? Thanks

baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review

@yas, rebased the patch.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for the update. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 68e4cb3 on 5.x authored by baldwinlouie 
    Issue #3308967 by baldwinlouie, yas: Hotfix - Add the function to edit...

  • yas committed 35c30e3 on 4.x 
    Issue #3308967 by baldwinlouie, yas: Hotfix - Add the function to edit...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.