Problem/Motivation

Speed up testbot and simplify tests by using the testing profile instead of the standard profile.

Steps to reproduce

Proposed resolution

Convert Drupal\Tests\workspaces\Functional\WorkspacesUninstallTest to use the testing profile, not the standard profile.

Remaining tasks

Update patch
Review
Commit

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#4 3308915-4.patch1.3 KBsmustgrave
#4 interdiff-2-4.txt1.03 KBsmustgrave
#2 3308915-2.patch1.36 KBsmustgrave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Active » Needs review
FileSize
3308915-2.patch1.36 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented 
+++ b/core/modules/workspaces/tests/src/Functional/WorkspacesUninstallTest.php
@@ -45,7 +42,7 @@ public function testUninstallingWorkspace() {
+    $this->createContentType(['type' => 'article']);

This is a strange place to set up a content type, this is usually done at the very start of the test method if possible.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
FileSize
interdiff-2-4.txt1.03 KB
3308915-4.patch1.3 KB
Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
Status: Needs review » Reviewed & tested by the community

- Concerns from @longwave in #3 we're addressed with patch #4.
- Code changes make sense to me.
- TestBot is green.

RTBC for me

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 10.1.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 6e97216f51 to 10.1.x and 5e55ae66ca to 10.0.x and 7d49d69f0b to 9.5.x and 356da9c057 to 9.4.x. Thanks!

Backported to 9.4.x to keep tests aligned.

  • alexpott committed 6e97216 on 10.1.x 
    Issue #3308915 by smustgrave, longwave: Fix test performance of Drupal\...

  • alexpott committed 5e55ae6 on 10.0.x 
    Issue #3308915 by smustgrave, longwave: Fix test performance of Drupal\...

  • alexpott committed 7d49d69 on 9.5.x 
    Issue #3308915 by smustgrave, longwave: Fix test performance of Drupal\...

  • alexpott committed 356da9c on 9.4.x 
    Issue #3308915 by smustgrave, longwave: Fix test performance of Drupal\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.