Problem/Motivation
It would be nice to have the SAML Attributes available in the ExternalAuth Register event. This makes it possible to alter some data on the account based on the SAML Attributes.
Proposed resolution
Pass on SAML Attributes to the ExternalAuth::register method.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3308562-4.patch | 723 bytes | Anonymous (not verified) |
Comments
Comment #1
Anonymous (not verified) commenteddfernandez1991 created an issue. See original summary.
Comment #2
Anonymous (not verified) commentedComment #3
Anonymous (not verified) commentedComment #4
Anonymous (not verified) commentedComment #5
Anonymous (not verified) commentedComment #6
john franklin commented+1 this patch.
Comment #8
roderikI prefer forcing you to use the SamlauthEvents::USER_SYNC event. Unless you can convince me you really need the ExternalAuth Register event.
Advantages of SamlauthEvents::USER_SYNC:
In exchange for the above two points, you must:
$event->markAccountChanged(), to prevent needless saves edit: that call isn't required for newly registered accounts because those are always savedif($event->getAccount()->isNew()if you want to act only on newly registered users.I've hopefully improved documentation to make clearer that this is also meant to be used during user registration.
I'll close this after a while if no feedback received.
Comment #9
roderikComment #10
roderik