Problem/Motivation

RestUIForm::__construct(... ModuleHandler $module_handler ...) should be RestUIForm::__construct(... ModuleHandlerInterface $module_handler ...)

Issue fork restui-3308271

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mrweiner created an issue. See original summary.

mrweiner opened merge request !1

mrweiner’s picture

mrweiner commented
Status: Active » Needs review
dpi’s picture

dpi
Location Perth, Australia
commented
Related issues: +#3308236: Use interfaces instead of classes to allow decorated services.

Many people are seeing errors related to ModuleHandler as a result of upgrading Hook Event Dispatcher, which includes a module handler service decorator.

Projects need to ensure interfaces are used while injecting services, so Rest UI will need to make the code change here.

dpi’s picture

dpi
Location Perth, Australia
commented
Related issues: -#3308236: Use interfaces instead of classes to allow decorated services. +#3277301: Adapt to centralised hook dispatcher in Drupal 9.4

incorrect ref

mrweiner’s picture

mrweiner commented

I should note that I'm seeing the issue for the same reason, but because of https://www.drupal.org/project/hux instead of Hook Event Dispatcher.

Ha, just saw that you're the hux maintainer. Thanks for that! Great module.

dpi’s picture

dpi
Location Perth, Australia
commented

Awesome! Good to have you on board.

It’s true, Hux will cause the same issue as exposed by HED.

kvantstudio’s picture

kvantstudio commented

Fix for me!

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Needs review » Reviewed & tested by the community

I can confirm this MR fixes the issue that arises when used in combination with hook_event_dispatcher module.

kristofferwiklund made their first commit to this issue’s fork.

kristofferwiklund’s picture

kristofferwiklund commented

Small fix so that the protected variable also is defined by its Interface. Otherwise it looks good.

clemens.tolboom made their first commit to this issue’s fork.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

TNX

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.