Problem/Motivation

Add possibility to alter the request in ImportService. The request in importChannel is not using the internal function.

Proposed resolution

Use the internal function.

User interface changes

Nothing to report.

API changes

Nothing to report.

Data model changes

Nothing to report.

Issue fork entity_share-3308018

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

MaxPah created an issue. See original summary.

MaxPah opened merge request !56

maxpah’s picture

maxpah
Primary language French
commented
Assigned: maxpah » Unassigned
Status: Active » Needs review

Grimreaper made their first commit to this issue’s fork.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper

  • Grimreaper committed 3c0b9c0e on 8.x-3.x authored by MaxPah 
    Issue #3308018 by MaxPah: Use internal ImportService::jsonApiRequest to...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Needs review » Fixed

Hi,

Thanks! Nice catch!

I forgot why I introduced the jsonApiRequest and request methods in the import service interface. I think it was for tests or to avoid to carry the remote manager service everywhere else. But yes ImportService should be consistent internally.

To alter the URLs you would also maybe like to override the remote manager service. But I think you would have already do that if needed for your use case :).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.