Problem/Motivation

In ModulesListForm.php line 266 string value is assigned to ['attributes']['class'] instead of an array which causes problems.

Proposed resolution

Assign the value to class attribute in the form of an array.

CommentFileSizeAuthor
#3 class_array-3307972-3.patch827 bytesrik.scholten
#2 class_array-3307972-2.patch0 bytesrik.scholten

Issue fork drupal-3307972

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

AlirezaK created an issue. See original summary.

rik.scholten’s picture

rik.scholten
Primary language Dutch
CreditAttribution: rik.scholten as a volunteer and at INDICIA commented
Status: Active » Needs review
FileSize
class_array-3307972-2.patch0 bytes
rik.scholten’s picture

rik.scholten
Primary language Dutch
CreditAttribution: rik.scholten as a volunteer and at INDICIA commented
FileSize
class_array-3307972-3.patch827 bytes

Ignore the previous patch please, it turned out empty on accident.

Pasqualle’s picture

Pasqualle
Location 🇭🇺 Budapest
CreditAttribution: Pasqualle as a volunteer commented
Status: Needs review » Reviewed & tested by the community

AlirezaK opened merge request !2790

AlirezaK’s picture

AlirezaK CreditAttribution: AlirezaK commented

I created the MR 2790 with the same solution of -3 patch which wraps the class value in [].

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.4.x-dev » 9.5.x-dev
Status: Reviewed & tested by the community » Fixed

Markup arrays are allowed to change in minor releases. We try to keep them consistent for bugfix releases and I'm not sure that we should be changing this in a bugfix release.

Committed and pushed f913fc46a7 to 10.1.x and 7eba074322 to 10.0.x and f6aa163c8a to 9.5.x. Thanks!

  • alexpott committed f913fc4 on 10.1.x 
    Issue #3307972 by AlirezaK, rik.scholten: ModulesListForm.php assigns...

  • alexpott committed 7eba074 on 10.0.x 
    Issue #3307972 by AlirezaK, rik.scholten: ModulesListForm.php assigns...

  • alexpott committed f6aa163 on 9.5.x 
    Issue #3307972 by AlirezaK, rik.scholten: ModulesListForm.php assigns...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.