Problem/Motivation
I think we could simply remove our dependency on @ckeditor/ckeditor5-dev-utils since we are no longer running the DLL build for upstream packages on our end. The issue where that changed was #3247711: Simplify and accelerate builds: update our use of the CKEditor 5 DLL manifest
(@lauriii in #2)
Original IS
Since #3301495: Update CKEditor 5 to 35.0.1 was committed, step [4/5] Linking dependencies... from the yarn install-phase shows:
warning "@ckeditor/ckeditor5-dev-utils > ts-loader@9.3.1" has unmet peer dependency "typescript@*".
No idea if this will summon a random party of four horsemen to appear in a blood red sky, but ideally we want no warnings.
Steps to reproduce
Start a Drupal CI test run an any issue with any combination of PHP/DB for 10.0.x or 10.1.x
Proposed resolution
Get rid of @ckeditor/ckeditor5-dev-utils
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 3307713-d95-10.patch | 80.86 KB | spokje |
Comments
Comment #2
lauriiiI think we could simply remove our dependency on
@ckeditor/ckeditor5-dev-utilssince we are no longer running the DLL build for upstream packages on our end. The issue where that changed was #3247711: Simplify and accelerate builds: update our use of the CKEditor 5 DLL manifest.Comment #3
spokjeRetitling + updated IS.
Comment #4
spokjeComment #5
spokjeNice clean-up:
Comment #6
spokje-
yarn installerror is gone:- No references to
ckeditor/ckeditor5-dev-utilsleft after applying patch.RTBC if TestBot agrees.
Comment #7
alexpottCan we do this on 9.5.x too?
Committed and pushed d0154b5bfd to 10.1.x and 46f4da7a8e to 10.0.x. Thanks!
Comment #10
spokjeComment #11
bnjmnm9.5 port looks good, and my manual tests on a local 9.5.x confirm that. Thanks @Spokje
Comment #12
lauriiiCommitted the backport to 9.5.x. 👍
Comment #14
xjmComment #15
phenaproximaThis is tagged for release notes (why, I don't know) but there are no release notes. Kicking back for that.
Comment #16
wim leersDo we really need release notes for a dev dependency of a module that was still "experimental" at the time of commit? 🤔
Comment #17
catchI don't think this needs a release note:
- the change only impacts core developers
- there is no API change, not even to the experimental or internal API of ckeditor
- given there is zero impact on sites, contrib developers, or themers, it will just make the release notes incredibly long so that people don't read things that actually need to know about.
Comment #18
wim leersPer #17.