Problem/Motivation

We have been working on replacing Classy with the new Starterkit Theme in #3050378: [meta] Replace Classy with a starterkit theme.

Proposed resolution

Deprecate Classy to be removed from core in Drupal 10.

Release notes snippet

The Classy theme has been deprecated in Drupal 9.5.0 and will be available as a contributed module for 10.0.0, the change record has recommendations for both new and existing projects.

CommentFileSizeAuthor
#9 interdiff_3-9.txt559 bytesSpokje
#9 3307241-9.patch1.36 KBSpokje
#3 interdiff.txt520 byteslauriii
#3 3307241-3.patch2.47 KBlauriii
#2 3307241-2.patch2.41 KBlauriii
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Active » Needs review
FileSize
3307241-2.patch2.41 KB
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
FileSize
3307241-3.patch2.47 KB
interdiff.txt520 bytes
Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Green TestBot
lifecycle_link: https://drupal.org/node/3223395#s-classy works
Code changes make sense

RTBC for me.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Status: Reviewed & tested by the community » Needs work

Hmm, just realized that we "normally" move all the tests into the module/theme to be deprecated first, so it can have a quicker and cleaner git subtree split when moving the module/theme to contrib, and we're sure it doesn't loose test-coverage.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Title: Deprecate Classy in favor of the new Starterkit Theme » [PP-1] Deprecate Classy in favor of the new Starterkit Theme
Status: Needs work » Postponed

To not slow down the deprecation/removal process (too much) I've bundled (hopefully) all of the moving and related issues here: #3307454: Move classy related tests to the theme directory/namespace or handle them otherwise.

Postponing this on that one.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm at Acquia commented
Title: [PP-1] Deprecate Classy in favor of the new Starterkit Theme » Deprecate Classy in favor of the new Starterkit Theme
Status: Postponed » Needs work
Issue tags: +Needs reroll

Un-postponed! #3307454: Move classy related tests to the theme directory/namespace or handle them otherwise

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Assigned: Unassigned » Spokje
Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Issue tags: -Needs reroll
FileSize
3307241-9.patch1.36 KB
interdiff_3-9.txt559 bytes
Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Assigned: Spokje » Unassigned
Status: Needs work » Needs review
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Needs review » Reviewed & tested by the community

Looks good!

  • catch committed 4a8c069 on 9.5.x 
    Issue #3307241 by lauriii, Spokje: Deprecate Classy in favor of the new...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed
Issue tags: +9.5.0 release notes

Committed/pushed to 9.5.x, thanks!

Added a release note.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.