Closed (fixed)
Project:
Workbench Access
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
31 Aug 2022 at 20:45 UTC
Updated:
20 Sep 2022 at 18:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #4
omkar-pd commentedAdded Confirmation message on
user/UID/workbench_access.Comment #5
agentrickardNot sure why those tests failed.
We should also inject the messenger service.
And the message should probably indicate the nature of the change, such as "added 2 sections" or "removed 1 section" or a list of add/remove.
Comment #6
agentrickardThe form processing doesn't really tell us what was added/removed, so just a confirm is fine.
Comment #7
omkar-pd commentedLooks good, moving this to RTBC.
Comment #8
omkar-pd commentedWe should also use Dependency Injection in other files as well. Let's fix that in another issue once this issue is fixed.
Comment #9
agentrickardIf you take a look at the README in the -dev branch, you'll see that is not currently required, but we should spin up a new ticket.
tl;dr; Here's what I'm testing with using PHPSTAN (in phpstan.neon):
Comment #11
agentrickardComment #12
agentrickardSee #3308225: Use dependency injection consistently