Hello,

I'd kindly like to apply this project for security coverage.
Fileslog basically replaces the 'dblog'-module in a sense, instead of logging all messages to the database it logs them to the private filesystem.
In some query-heavy sites, this can take a huge load off of the database.
Logs can also be automatically deleted when exceeding a certain amount (similar to dblog).
The 'recent log messages'-table has also been recreated, and the usage for the end-user of this module is nearly 1:1 equal to dblog, meaning the switch is not hard to make and they will instantly be familiar with its interface.

Project link

https://www.drupal.org/project/fileslog

Git instructions

git clone --branch 1.0.x https://git.drupalcode.org/project/fileslog.git

Comments

RandalV created an issue. See original summary.

randalv’s picture

randalv commented

In the meantime, my co-maintainer seems to have checked the security checkbox.

I would, however, still like to have it reviewed so perhaps I, too, can opt in to the security advisory checkbox in the future.

jaroslav červený’s picture

jaroslav červený commented

Hi, I find:

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

FILE: C:\wamp\www\fileslog\fileslog.install
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: C:\wamp\www\fileslog\src\Controller\FilesLogController.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
225 | ERROR | Description for the @return value is missing
----------------------------------------------------------------------

FILE: C:\wamp\www\fileslog\src\Form\FileslogFilterForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
26 | ERROR | [ ] Description for the @return value is missing
36 | WARNING | [x] There must be no blank line following an inline comment
36 | WARNING | [x] '@todo: can we filter by category somehow?' should match
| | the format '@todo Fix problem X here.'
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: C:\wamp\www\fileslog\src\Logger\FilesLog.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
33 | ERROR | [ ] Doc comment for parameter $config_factory does not match
| | actual variable name $parser
87 | WARNING | [x] There must be no blank line following an inline comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 3.3 secs; Memory: 10MB

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
randalv’s picture

randalv commented
Status: Needs work » Needs review

Thank you for your review @Jaroslav!

I've corrected the mistakes in 1.0.x, see:

randalvanheede➜modules/custom/fileslog(1.0.x✗)» ../../../../vendor/bin/phpcs  --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .               [9:52:21]
randalvanheede➜modules/custom/fileslog(1.0.x✗)»
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community 
  /**
   * The filesystem service.
   *
   * @var \Drupal\Core\File\FileSystemInterface
   */
  protected FileSystemInterface $fileSystem;

  /**
   * The current request.
   *
   * @var \Symfony\Component\HttpFoundation\Request|null
   */
  protected ?Request $request;

Drupal 9 still requires PHP 7.3. A project that uses features implemented in newer PHP versions should explicitly require that PHP version, or require only Drupal 10.x.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.