Noticed a query on the node table in a case where in 99% of cases the node will already be cached in memory. If we're viewing comments, we're almost always viewing their parent node too. If we're not viewing the parent node, then it's on pages like comment/n/reply where performance is less of an issue than node/n anyway.

CommentFileSizeAuthor
#3 comment_mode_queries.patch777 bytescatch
comment_mode.patch1.39 KBcatch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

lilou’s picture

lilou CreditAttribution: lilou commented
Status: Needs work » Needs review

See: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
FileSize
comment_mode_queries.patch777 bytes

re-roll since re-test reports seem to be stuck and this one doesn't have 30 lines of cvs crud at the top of it.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

Good catch! Committed to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.