Problem/Motivation

Test module twig_theme_test depends on ckeditor in twig_theme_test.attach_library.html.twig.
ckeditor Is on its way out of core, let's replace it with the up and coming star ckeditor5.

Steps to reproduce

Proposed resolution

Replace ckeditor with ckeditor5 in core/modules/system/tests/modules/twig_theme_test/templates/twig_theme_test.attach_library.html.twig

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3306720

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Spokje created an issue. See original summary.

spokje’s picture

Marking this as critical since the parent issue is marked critical.

spokje’s picture

Title: Replace ckeditor with ckeditor5 in core/modules/system/tests/modules/twig_theme_test/templates/twig_theme_test.attach_library.html.twig » Replace ckeditor with ckeditor5 in twig_theme_test.attach_library.html.twig
spokje’s picture

Status: Active » Needs review
wim leers’s picture

Status: Needs review » Reviewed & tested by the community

RTBC +1

This simplifies #3304326: Deprecate CKEditor 4 module in 9.5 slightly.

spokje’s picture

And makes the above and #3270438: Remove CKEditor 4 from core independent of each other.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed e09d527af8 to 10.1.x and 9982e89c54 to 10.0.x and f3cbce243e to 9.5.x. Thanks!

  • alexpott committed e09d527 on 10.1.x
    Issue #3306720 by Spokje: Replace ckeditor with ckeditor5 in...

  • alexpott committed 9982e89 on 10.0.x
    Issue #3306720 by Spokje: Replace ckeditor with ckeditor5 in...

  • alexpott committed f3cbce2 on 9.5.x
    Issue #3306720 by Spokje: Replace ckeditor with ckeditor5 in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.