Problem/Motivation

In #3231341: Deprecate EditorLinkDialog, EditorImageDialog and EditorMediaDialog in Drupal 10.1 for removal in Drupal 11 we're deprecating EditorLinkDialog, EditorImageDialog and EditorMediaDialog for removal in Drupal 10.

When that issue lands, this issue is here for the actual removal.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3306584

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#3231341: Deprecate EditorLinkDialog, EditorImageDialog and EditorMediaDialog in Drupal 10.1 for removal in Drupal 11
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes

Currently postponed on #3231341: Deprecate EditorLinkDialog, EditorImageDialog and EditorMediaDialog in Drupal 10.1 for removal in Drupal 11

spokje’s picture

spokje
Primary language Dutch
commented
Title: [PP-1] Remove EditorLinkDialog, EditorImageDialog and EditorMediaDialog in Drupal 10 » [PP-1] Remove EditorLinkDialog, EditorImageDialog and EditorMediaDialog in Drupal 11
Version: 10.0.x-dev » 10.1.x-dev
spokje’s picture

spokje
Primary language Dutch
commented
Version: 10.1.x-dev » 11.0.x-dev
catch’s picture

catch
he/him
Primary language English
commented
Title: [PP-1] Remove EditorLinkDialog, EditorImageDialog and EditorMediaDialog in Drupal 11 » [11.x] Remove EditorLinkDialog, EditorImageDialog and EditorMediaDialog in Drupal 11
Version: 11.0.x-dev » 11.x-dev
Issue tags: +Major version only

Spokje changed the visibility of the branch 3306584- to hidden.

Spokje changed the visibility of the branch 3306584- to hidden.

Spokje opened merge request !6853

spokje’s picture

spokje
Primary language Dutch
commented
Status: Postponed » Needs review

Right...forgot how messy/interesting the QuickEdit spin-offs were.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

This looks great!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

(FYI the sibling #3239012: [11.x] Remove the CKEditor 4 upgrade path is ready for review too!)

  • catch committed 9144c96a on 11.x 
    Issue #3306584 by Spokje, Wim Leers: [11.x] Remove EditorLinkDialog,...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed 
+ 8
− 1361

!!

Committed/pushed to 11.x, thanks!

catch closed merge request !6853

spokje’s picture

spokje
Primary language Dutch
commented 
+ 8
− 1361

Somehow this looks eerily like my bank statements, but in here I'll take that as a win.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

@Spokje: 🤣

quietone’s picture

quietone commented
Parent issue: » #3295574: [meta] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 11 branch
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

This having landed allowed me to close/triage a LOT of issues:

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

quietone commented
Version: 11.x-dev » 11.0.x-dev

Update version to the branch this applies to.