In the D6 version, the module configuration screen, at admin/settings/filters/<input format>/configure looks awkward when compared with the D5 version, although it works when one understands its appearance.

This is because the module theme function is ignored in D6, which only recognizes such functions when a module implements hook_theme().

The attached patch declares this function and restores the D5 user interface in the D6 version.

CommentFileSizeAuthor
#9 Screen Shot 2014-09-05 at 23.10.46.png68.67 KBosopolar
hook_theme.patch1.35 KBfgm

Comments

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs review » Fixed

No answers after almost two months: assuming fixed, included in today's dev release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
Issue summary: View changes
Status: Closed (fixed) » Needs work

Module configuration screen is still not themed. It seems that theme_url_replace_filter_settings_form() does not get called.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Assigned: Unassigned » fgm
Priority: Minor » Normal
Status: Needs work » Active

Indeed : this worked when it was committed 6 yars ago, but Drupal 6 changed in the meantime.

  • fgm committed 498438f on 6.x-1.x 
    Issue #330640 by fgm: Theme module configuration form.

- Added...
fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Assigned: fgm » Unassigned
fgm’s picture

fgm
Primary language French
Location Paris, France
commented

@osopolar: can you check if this is also fixed for you after updating to the latest dev version ?

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Active » Fixed

This seems to be fixed. Feel free to reopen otherwise.

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
StatusFileSize
new Screen Shot 2014-09-05 at 23.10.46.png68.67 KB

Thanks for committing the changes. It seems to work well now in current beta release, see screenshot:

fgm’s picture

fgm
Primary language French
Location Paris, France
commented

Thanks for your confirmation.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.