Problem/Motivation

  • Add the function to list Openstack Launch Template in the SPA.

Issue fork cloud-3306380

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Masami created an issue. See original summary.

Masami opened merge request !1241

masami’s picture

masami commented
Status: Active » Needs review
ryo yamashita’s picture

ryo yamashita commented

@masami

It looks good to me. Thanks.

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas @masami

I fixed launch_tempate.ts to correct the display in OpenStack. Please review it. Thanks.

masami’s picture

masami commented
Status: Needs review » Needs work

@Ryo Yamashita @yas
I added the comment. Please confirm.

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@masami @yas

I pushed the commit ec3ee3c7. Thanks.

masami’s picture

masami commented

@Ryo Yamashita @yas
I added 2 more comments. Please confirm.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work

@masami

Thank you for your review.

@ryo-yamashita

Can you please confirm her comments? Thanks

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
ryo yamashita’s picture

ryo yamashita commented

@yas @masami

Based on your comments, I have pushed the patch. Thanks.

masami’s picture

masami commented
Status: Needs review » Reviewed & tested by the community

@Ryo Yamashita @yas
The patch now looks good to me, so I change the status to RTBC.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@masami

Thank you for your review.

@ryo-yamashita

Thank you for the update. ll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 62d1551 on 5.x authored by Masami 
    Issue #3306380 by Ryo Yamashita, Masami, yas: Add the function to list...

  • yas committed e8c928f on 4.x 
    Issue #3306380 by Ryo Yamashita, Masami, yas: Add the function to list...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.