Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#10 3304901-one-time.patch2.6 KBbnjmnm

Issue fork drupal-3304901

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

bnjmnm opened merge request !2650

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Active » Needs review

MR runs the fix 800x

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Fix intermittently failing Functional Javascript tests » Fix intermittently failing Settings Tray Functional Javascript tests
xjm’s picture

xjm
she/her
Primary language English
commented
Related issues: +#3267247: [meta] Fix and re-enable tests skipped for random failures

nod_ made their first commit to this issue’s fork.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

Test iterations are set to 400, can't get much higher without timing out.

xjm’s picture

xjm
she/her
Primary language English
commented

Queued a few more, for science, but pending those results I think it's pretty clear the off-canvas fix is applicable to this test and has resolved the fail. So we just need a commit version after that.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

Test fix looks good, we have the trait so we should use it.

NW to remove the DrupalCI changes.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs work » Needs review
StatusFileSize
new 3304901-one-time.patch2.6 KB
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

👍

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: bnjmnm » Unassigned

Thanks to #3268680: [random test failure] Restore and fix LayoutBuilderDisableInteractionsTest::testFormsLinksDisabled() for providing OffCanvasTestTrait, very nice!
Verifying that this is RTBC.

  • xjm committed 2b3f1b9 on 10.1.x 
    Issue #3304901 by bnjmnm, nod_: Fix intermittently failing Settings Tray...

  • xjm committed 5349c9f on 10.0.x 
    Issue #3304901 by bnjmnm, nod_: Fix intermittently failing Settings Tray...

  • xjm committed ef4c3e6 on 9.5.x 
    Issue #3304901 by bnjmnm, nod_: Fix intermittently failing Settings Tray...

  • xjm committed 30ac3b4 on 9.4.x 
    Issue #3304901 by bnjmnm, nod_: Fix intermittently failing Settings Tray...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed to 10.1.x, 10.0.x, 9.5.x, and 9.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.