Problem/Motivation

CKEditor 4 will be deprecated in Drupal 9.5.0.

Proposed resolution

Update references to CKEditor 4 in core/modules/help_topics/help_topics/editor.overview.html.twig to mention CKEditor 5 instead.

CommentFileSizeAuthor
#2 3304596-2.patch4.74 KBlauriii

Issue fork drupal-3304596

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Active » Needs review
FileSize
3304596-2.patch4.74 KB

bnjmnm made their first commit to this issue’s fork.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm at Acquia commented

This needs to happen, but should it be in 9.5 where the standard install still uses CKEditor 4? It's also possible that's just the default version when the issue was created...

bnjmnm opened merge request !2642

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Parent issue: » #3270437: [meta] Tasks to deprecate the CKEditor 4 module

This needs to happen, but should it be in 9.5 where the standard install still uses CKEditor 4?

Yeah I also think it should happen in 10.0.x, but then again … this is one of the steps listed in #3270437: [meta] Tasks to deprecate the CKEditor 4 module.

Actually, I think the point is that this should land after the CKEditor 5 module is not only marked stable (which MUST happen in 9.5.x) but also made the new default (which AFAIK also should happen in 9.5.x). So then 9.5.x does make sense 😊

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community

The changes look great to me, they even improve the accuracy of the text compared to what's in HEAD! 👍

The changes look RTBC. I defer to core committers on commit order. But given that we've widely announced that the CKEditor 4 module will be deprecated in 9.5.x and CKEditor 5 will be the successor, plus the fact that Drupal 10 must ship with CKEditor 5, I don't think we necessarily need to wait for the other steps listed in #6 to truly land first — we need all of that to happen anyway!

  • lauriii committed 9d82b6d on 10.1.x 
    Issue #3304596 by bnjmnm, lauriii, Wim Leers: Update editor help topic...

  • lauriii committed 0eb9222 on 10.0.x 
    Issue #3304596 by bnjmnm, lauriii, Wim Leers: Update editor help topic...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented

CKEditor 5 is listed as a Drupal 10.0.0-beta1 requirement in #3118149: [meta] Requirements for tagging Drupal 10.0.0-beta1. Based on that, committed to 10.1.x and 10.0.x. If we decide to go with another editor solution for beta1 or decide to continue using CKEditor 4, reverting this commit is going to be least of our problems. 🤪

Committed 9d82b6d and pushed to 10.1.x. Cherry-picked to 10.0.x. Thanks!

Leaving open for 9.5.x. backport once CKEditor 5 is stable.

lauriii closed merge request !2642

  • lauriii committed abc9e1f on 9.5.x 
    Issue #3304596 by bnjmnm, lauriii, Wim Leers: Update editor help topic...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Reviewed & tested by the community » Fixed

Discussed with @xjm and based on that backported to 9.5.x with the same justification I already gave to 10.0.x 😅

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.