Problem/Motivation

  • Add the function to create AWS Subnet in the SPA

Issue fork cloud-3304580

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie opened merge request !1224

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review

@yas Patch attached.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes

@baldwinlouie

Thank you for the patch. It looks good to me.

@ryo-yamashita

What do you think?

Thanks

ryo yamashita’s picture

ryo yamashita commented

@yas

It looks good to me, too. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for your review.

@baldwinlouie

Can you please rebase the patch? Thanks!

baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review

@yas, the patch has been rebased.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for rebasing the patch. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed e9d6ea7 on 4.x 
    Issue #3304580 by baldwinlouie, yas, Ryo Yamashita: Add the function to...

  • yas committed 5e7e072 on 5.x authored by baldwinlouie 
    Issue #3304580 by baldwinlouie, yas, Ryo Yamashita: Add the function to...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.