Phpcs Drupal standard coding issue [#3304439]

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\config\schema\image_style_template.schema.yml
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
13 | ERROR | [x] Expected 1 newline at end of file; 2 found
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\modules\pagedesigner_focal_point\pagedesigner_focal_point.install
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\pagedesigner_responsive_images.install
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\pagedesigner_responsive_images.libraries.yml
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Expected 1 newline at end of file; 3 found
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\pagedesigner_responsive_images.module
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\pagedesigner_responsive_images.services.yml
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Expected 1 newline at end of file; 5 found
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\README.md
-------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 17 WARNINGS AFFECTING 17 LINES
-------------------------------------------------------------------------------------------
4 | WARNING | Line exceeds 80 characters; contains 252 characters
6 | WARNING | Line exceeds 80 characters; contains 97 characters
11 | WARNING | Line exceeds 80 characters; contains 83 characters
14 | WARNING | Line exceeds 80 characters; contains 117 characters
15 | WARNING | Line exceeds 80 characters; contains 88 characters
16 | WARNING | Line exceeds 80 characters; contains 89 characters
22 | WARNING | Line exceeds 80 characters; contains 359 characters
25 | WARNING | Line exceeds 80 characters; contains 298 characters
38 | WARNING | Line exceeds 80 characters; contains 147 characters
42 | WARNING | Line exceeds 80 characters; contains 139 characters
82 | WARNING | Line exceeds 80 characters; contains 87 characters
83 | WARNING | Line exceeds 80 characters; contains 107 characters
84 | WARNING | Line exceeds 80 characters; contains 118 characters
86 | WARNING | Line exceeds 80 characters; contains 110 characters
102 | WARNING | Line exceeds 80 characters; contains 256 characters
161 | WARNING | Line exceeds 80 characters; contains 181 characters
171 | WARNING | Line exceeds 80 characters; contains 88 characters
-------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\resources\css\responsive-images.css
---------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
1 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
6 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\src\Entity\ImageStyleTemplate.php
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\src\Form\ImageStyleTemplateDeleteForm.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\src\Form\ImageStyleTemplateForm.php
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\src\Form\PagedesignerResponsiveImagesSettingsForm.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\src\ImageStyleTemplateListBuilder.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\src\PathProcessor\ImageStylePathProcessor.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\src\Plugin\Field\FieldFormatter\ResponsiveImageFieldFormatter.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\src\Plugin\pagedesigner\Handler\ComponentSizes.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\src\Plugin\pagedesigner\Handler\ImageStyleTemplate.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\src\Plugin\pagedesigner\Handler\ResponsiveImage.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\src\Plugin\pagedesigner\Handler\ResponsiveImageGalleryGallery.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\pagedesigner_responsive_images\src\ResponsiveImageStylesTwigExtension.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
8 | WARNING | [x] Unused use statement
52 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

Comment	File	Size	Author
#5	Drupal-standard-coding-issue-3304439-5.patch	40.06 KB	dharti patel
#3	Drupal-standard-coding-issue-3304439-3.patch	9.43 KB	Harsh panchal

Issue fork pagedesigner_responsive_images-3304439

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3304439-phpcs-drupal-standard changes, plain diff MR !10
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Assigned:	Harsh panchal	» Unassigned
Category:	Task	» Bug report
Status:	Active	» Needs review

Status	File	Size
new	Drupal-standard-coding-issue-3304439-3.patch	9.43 KB

Comment #4

dharti patel commented 4 November 2022 at 09:42

Assigned:

Unassigned

» dharti patel

Comment #5

dharti patel commented 4 November 2022 at 12:57

Assigned:

dharti patel

» Unassigned

Status	File	Size
new	Drupal-standard-coding-issue-3304439-5.patch	40.06 KB

Hello,

Reviewed the #3 patch and after applying the patch faced the below errors.

FILE: /home/drupal/d9-open/pagedesigner_responsive_images/src/ImageStyleTemplateListBuilder.php
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------
 19 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 20 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 40 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------

FILE: /home/drupal/d9-open/pagedesigner_responsive_images/src/ResponsiveImageStylesTwigExtension.php
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------
 50 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 52 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 80 | WARNING | ImageStyle::load calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------

FILE: /home/drupal/d9-open/pagedesigner_responsive_images/src/PathProcessor/ImageStylePathProcessor.php
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
 28 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------

FILE: /home/drupal/d9-open/pagedesigner_responsive_images/resources/js/init-responsive-images.js
-------------------------------------------------------------------------------------------------------
FOUND 36 ERRORS AFFECTING 23 LINES
-------------------------------------------------------------------------------------------------------
   1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
   7 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
   7 | ERROR | [x] Expected 1 space before opening brace; found 0
  14 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  14 | ERROR | [x] Expected 1 space before opening brace; found 0
  27 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  27 | ERROR | [x] Expected 1 space before opening brace; found 0
  28 | ERROR | [x] Expected 1 space before "+"; 0 found
  43 | ERROR | [x] Expected 1 space after "="; 2 found
  43 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  43 | ERROR | [x] Expected 1 space before opening brace; found 0
  45 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  45 | ERROR | [x] Expected 1 space before opening brace; found 0
  49 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  49 | ERROR | [x] Expected 1 space before opening brace; found 0
  59 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 108 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 108 | ERROR | [x] Expected 1 space before opening brace; found 0
 110 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 110 | ERROR | [x] Expected 1 space before opening brace; found 0
 111 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 111 | ERROR | [x] Expected 1 space before opening brace; found 0
 123 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 124 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 124 | ERROR | [x] Expected 1 space before opening brace; found 0
 126 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 126 | ERROR | [x] Expected 1 space before opening brace; found 0
 129 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 155 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 267 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
 289 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 292 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
 307 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 313 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 313 | ERROR | [x] Expected 1 space before opening brace; found 0
 328 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 36 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------

Resolved the above issues and create a new patch for the same.

Thanks!

Comment #6

gabrieldv commented 4 November 2022 at 13:00

Assigned:

Unassigned

» gabrieldv

I'll review this, thanks for the patches :)

Comment #7

gabrieldv commented 4 November 2022 at 14:00

Assigned:	gabrieldv	» Unassigned
Status:	Needs review	» Reviewed & tested by the community

It looks fine to me, tested the PHPCS with the standard=Drupal,DrupalPractice so i'm moving it to RTBC.

Resolve #3304439 "Phpcs drupal standard"

Comment #11

pvbergen commented 30 January 2023 at 07:20

Status:	Reviewed & tested by the community	» Fixed
Issue tags:	-

Comment #12

13 February 2023 at 07:24

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Phpcs Drupal standard coding issue

Issue fork pagedesigner_responsive_images-3304439

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

News items

Our community

Documentation

Drupal code base

Governance of community