Problem/Motivation

To make it easier for other developers to contribute code, let's update Piwik Pro to follow the Drupal coding standards.

Proposed resolution

Update the code to follow Drupal coding standards

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#4 coding_standards_fixed-3304294-2.patch7.13 KBmeeni_dhobale

Issue fork piwik_pro-3304294

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr opened merge request !1

idebr’s picture

idebr commented
Status: Active » Needs review

https://git.drupalcode.org/project/piwik_pro/-/merge_requests/1 updates the code to follow Drupal coding standards.

meeni_dhobale’s picture

meeni_dhobale commented
StatusFileSize
new coding_standards_fixed-3304294-2.patch7.13 KB

I tried to resolve the coding standard issues. Adding patch for it. Please review it.

  • d777378 committed on 1.0.x 
    Issue #3304294: Update code to follow Drupal coding standards
joshahubbers’s picture

joshahubbers commented

I merged the request of idebr because it was more complete.

joshahubbers’s picture

joshahubbers commented
Status: Needs review » Fixed

  • idebr authored f8658a5 on 1.0.x 
    Issue #3304294 by idebr, JoshaHubbers: Update code to follow Drupal...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.