$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml icon_select/
Xdebug: [Step Debug] Time-out connecting to debugging client, waited: 200 ms. Tried: localhost:9000 (through xdebug.client_host/xdebug.client_port) :-(

FILE: C:\Users\SI-001\Downloads\icon_select\icon_select.module
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
146 | ERROR | The array declaration extends to column 86 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\Users\SI-001\Downloads\icon_select\README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
15 | WARNING | Line exceeds 80 characters; contains 162 characters
----------------------------------------------------------------------

Time: 565ms; Memory: 10MB

CommentFileSizeAuthor
#18 interdiff-0_18.txt293 bytesurvashi_vora
#18 3303954-fixed-coding-standards-18.patch3.67 KBurvashi_vora
#14 3303954-fixing_coding_standards.patch3.29 KBviniciuscosta
#13 3303954-fixing_coding_standards.patch0 bytesviniciuscosta
#8 drupal-coding-standard-issue-3303954-8.patch3.69 KBcinarb
#5 drupal-coding-standard-issue-3303954-3.patch1.78 KBLeoAlcci
#2 drupal-coding-standard-issue-3303954-2.patch1.39 KBrakhi soni

Issue fork icon_select-3303954

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Rakhi Soni created an issue. See original summary.

rakhi soni’s picture

rakhi soni commented
Assigned: rakhi soni » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal-coding-standard-issue-3303954-2.patch1.39 KB

Kindly review patch,,

mauryarahul11’s picture

mauryarahul11
Location Mumbai, India
commented
Status: Needs review » Needs work

Thanks @Rakhi Soni for your patch it fixes all the warnings given by phpcs except one in twig file (given below) which i can see why because you haven't added twig extension in your phpcs command. So moving it to Needs Work.

FILE: /icon_select/templates/icon-select-svg-icon.html.twig
--------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------
 3 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------
LeoAlcci’s picture

LeoAlcci commented
Assigned: Unassigned » LeoAlcci

I will take care of it!

LeoAlcci’s picture

LeoAlcci commented
Assigned: LeoAlcci » Unassigned
Status: Needs work » Needs review
StatusFileSize
new drupal-coding-standard-issue-3303954-3.patch1.78 KB

Add a new line to fix coding stadards.
Kindly review the patch =)

cinarb’s picture

cinarb commented

I'll review :)

cinarb’s picture

cinarb commented
Assigned: Unassigned » cinarb
cinarb’s picture

cinarb commented
Assigned: cinarb » Unassigned
StatusFileSize
new drupal-coding-standard-issue-3303954-8.patch3.69 KB

After running phpcs I found more drupal code standards to fix on js files.
I added these new changes. =D

christyanpaim’s picture

christyanpaim commented
Assigned: Unassigned » christyanpaim
christyanpaim’s picture

christyanpaim commented
Assigned: christyanpaim » Unassigned
Status: Needs review » Needs work

Apparently the module is not working well after the changes on JS files.

viniciuscosta’s picture

viniciuscosta commented
Status: Needs work » Active

Hi, I'll take care of it!

viniciuscosta’s picture

viniciuscosta commented
Assigned: Unassigned » viniciuscosta
viniciuscosta’s picture

viniciuscosta commented
Status: Active » Needs review
StatusFileSize
new 3303954-fixing_coding_standards.patch0 bytes
viniciuscosta’s picture

viniciuscosta commented
StatusFileSize
new 3303954-fixing_coding_standards.patch3.29 KB
viniciuscosta’s picture

viniciuscosta commented
Assigned: viniciuscosta » Unassigned
urvashi_vora’s picture

urvashi_vora commented
Assigned: Unassigned » urvashi_vora

Hi,

I will review this

urvashi_vora’s picture

urvashi_vora commented

Hi ,

Your patch applied cleanly, only one issue found. I will provide a patch for it.

urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib/icon_select-3303954$ git apply -v 3303954-fixing_coding_standards_0.patch
Checking patch README.md...
Checking patch icon_select.module...
Applied patch README.md cleanly.
Applied patch icon_select.module cleanly.
urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib/icon_select-3303954$ cd ..
urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig icon_select-3303954/

FILE: ...dules/contrib/icon_select-3303954/templates/icon-select-svg-icon.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 736ms; Memory: 10MB

urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib$
urvashi_vora’s picture

urvashi_vora commented
Assigned: urvashi_vora » Unassigned
StatusFileSize
new 3303954-fixed-coding-standards-18.patch3.67 KB
new interdiff-0_18.txt293 bytes

Hi,

I created a patch and an interdiff.

atul_ghate’s picture

atul_ghate commented

Hi,
i will review this patch.

atul_ghate’s picture

atul_ghate commented
Status: Needs review » Reviewed & tested by the community

The patch was applied cleanly and there were no PHPCS errors.

cbessire’s picture

cbessire commented
Issue tags: -

  • 772cb65e committed on 2.0.x 
    #3303954 -  phpcs fixes

  • 9a3880a8 committed on 3.0.x 
    #3303954 -  phpcs fixes
cbessire’s picture

cbessire commented
Version: 2.0.x-dev » 2.0.3
Status: Reviewed & tested by the community » Fixed

Merged on 2.0.x branch and rerolled upstream on 3.0.x betas.

Thanks for your contributions

ayalon’s picture

ayalon commented
Status: Fixed » Closed (fixed)