Problem/Motivation

A new JavaSrcript Messages API was introduced in Drupal 8.7. In order for themes to support this the status-messages.html.twig template markup must be wrapped in a div with the data-drupal-messages attribute applied.

This theme currently does not have the required attribute.

Steps to reproduce

  1. Compare suggested markup at https://www.drupal.org/node/2935209 to the current status-messages.html.twig markup.

Proposed resolution

Wrap the markup in status-messages.html.twig in a <div data-drupal-messages> element.

Remaining tasks

  1. Create patch.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork uswds_base-3303429

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

PCate created an issue. See original summary.

PCate opened merge request !33

pcate’s picture

pcate commented
Assigned: pcate » Unassigned
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Reviewed the CR and the MR and looks like they line up.

mferanda’s picture

mferanda commented
Status: Reviewed & tested by the community » Fixed
mferanda’s picture

mferanda commented
Status: Fixed » Closed (fixed)

mferanda closed merge request !33